Summary: | Add utf8 output to CSV output of overdue_notices.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | davewood |
Component: | Command-line Utilities | Assignee: | davewood |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | davewood, robin |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch to set the correct encoding for the CSV output file
add utf8 encoding for csv file output |
Description
davewood
2025-02-03 20:23:38 UTC
the change i included in the first bug report at least produces a file where german umlaut "Ö" (UTF-8 hex c3 96) and "č" (UTF-8 hex c4 8d) seem to be encoded correctly. Hi, do you want to provide the patch file? If you are working with koha-testing docker you can use: git bz attach. If not, a file generated with git format-patch HEAD^ or similar works too. You might want to check the correct name/email address is included in the header lines. Created attachment 177496 [details] [review] patch to set the correct encoding for the CSV output file Testplan: I) Prepare overdue entry (intranet): 0) Create a patron account with surname Höfler 1) Check if in Patron category administration the overdue column is YES for his code 2) In Tools -> Notice triggers define first delay = 7, letter Overdue notice. Nothing for second and third 3) Check if Tools -> Notices and slips, code overdue is available 4) checkout a book with a retard more than 7 days. 5) Check if Adminstration -> Defining circulation and fine rules for all libraries has fine rules for his patron category, item type book. II) Before applying the patch 0) Run misc/cronjobs/overdue_notices.pl -v -test -list-all -csv="overdue_old.csv" 1) Validate the characters are in Latin1 encoding. (hexdump -C overdue.csv|less) ö => "f6" III) After applying the patch 0) Run misc/cronjobs/overdue_notices.pl -v -test -list-all -csv="overdue_fixed.csv" 1) Validate the characters are in UTF-8 encoding. (hexdump -C overdue_fixed.csv|less) ö => "c3 b6" Sponsored-by: Styrian State Library Created attachment 177507 [details] [review] add utf8 encoding for csv file output new patch including testplan and sponsored-by statement |