Summary: | ILL plugins should provide themselves the template path | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | ILL | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | Patch doesn't apply --- | QA Contact: | Pedro Amorim <pedro.amorim> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, martin.renvoize, nick, pedro.amorim, tomascohen |
Version: | Main | Keywords: | rel_24_05_candidate, rel_24_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 19605 | ||
Bug Blocks: | |||
Attachments: |
Bug 39031: Use the backend's bundle_path() method
Bug 39031: Use the backend's bundle_path() method |
Description
Tomás Cohen Arazi (tcohen)
2025-02-04 19:46:35 UTC
I feel like just changing it like this would be flexible enough, while keeping the current behavior for plugin-as-a-backend implementations: ```diff - $backend_dir = $backend_plugin->bundle_path; + $backend_dir = $self->_backend->bundle_path; ``` The only weird thing that will be left in this scenario, is that both `$backend_plugin` and `$self->_backend` are instances of the same plugin... just with some extra internal variables set by `new_ill_backend()`. But in this context we already have an instance of the plugin, loaded 'as a backend' by `new_ill_backend()`. So it is redundant to instantiate the plugin, it seems. Created attachment 177533 [details] [review] Bug 39031: Use the backend's bundle_path() method Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Assigning Pedro for QA to get his review. And please backport :-D Created attachment 180483 [details] [review] Bug 39031: Use the backend's bundle_path() method Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> |