Bug 39040

Summary: Incorrect row striping in POS transaction sales table
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Point of SaleAssignee: Lucas Gass (lukeg) <lucas>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: barbara.johnson, m.de.rooy, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39040: Add CSS back via _tables.scss
Bug 39040: Add CSS back via _tables.scss
Bug 39040: Add CSS back via _tables.scss

Description Lucas Gass (lukeg) 2025-02-05 14:51:43 UTC
Prior to Bootstrap 5 (at least I think it was caused by BS update ) each transaction line had a highlighted grey background and each itemized line underneath it was alternating striping ( white/grey ). Now each transaction line has a white background, instead of grey, making it a bit more challenging to read. 

TO recreate:
1/ Turn on POS
2/ Enable Cash registers
3/ Configure some items for sale
4/ Make some POS transactions
5/ Visit pos/register.pl?registerid=x 
6/ Notice the problem described
Comment 1 Lucas Gass (lukeg) 2025-02-10 17:23:18 UTC
It looks like the style was coming from a removed file, rowGroup.dataTables.min.css 

Owen suggested I add back via _tables.scss
Comment 2 Lucas Gass (lukeg) 2025-02-10 17:25:46 UTC
Created attachment 177705 [details] [review]
Bug 39040: Add CSS back via _tables.scss

To test:

1/ Turn on POS
2/ Enable Cash registers
3/ Configure some items for sale
4/ Make some POS transactions
5/ Visit pos/register.pl?registerid=x
6/ Notice the problem described
7/ APPLY PATCH and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
8/ Look at the table again. The rows should now be correctly highlighted.
Comment 3 PTFS Europe Sandboxes 2025-02-10 22:16:46 UTC
Created attachment 177712 [details] [review]
Bug 39040: Add CSS back via _tables.scss

To test:

1/ Turn on POS
2/ Enable Cash registers
3/ Configure some items for sale
4/ Make some POS transactions
5/ Visit pos/register.pl?registerid=x
6/ Notice the problem described
7/ APPLY PATCH and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
8/ Look at the table again. The rows should now be correctly highlighted.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 4 Marcel de Rooy 2025-02-14 09:14:59 UTC
Created attachment 178091 [details] [review]
Bug 39040: Add CSS back via _tables.scss

To test:

1/ Turn on POS
2/ Enable Cash registers
3/ Configure some items for sale
4/ Make some POS transactions
5/ Visit pos/register.pl?registerid=x
6/ Notice the problem described
7/ APPLY PATCH and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
8/ Look at the table again. The rows should now be correctly highlighted.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Katrin Fischer 2025-02-17 14:07:25 UTC
Pushed for 25.05!

Well done everyone, thank you!