Bug 39045

Summary: Add translation context for "Active" and "Inactive"
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, jonathan.druart, lisette
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39061    
Bug Blocks:    
Attachments: Bug 39045: Add translation context to vendor status (active/inactive)
Bug 39045: Add translation context to currency active status
Bug 39045: Add translation context to budget active status
Bug 39045: Add translation context to stock rotation active status
Bug 39045: Add translation context to vendor status (active/inactive)
Bug 39045: Add translation context to course status (active/inactive)
Bug 39045: Add translation context to stock rotation status (active/inactive)
Bug 39045: Add translation context to 'Inactive' as report group
Bug 39045: Add translation context to API key active status
Bug 39045: Add translation context to ERM data providers status (active/inactive)
Bug 39045: Add translation context to fund status (inactive)
Bug 39045: Add translation context to currency active status
Bug 39045: Add translation context to budget active status
Bug 39045: Add translation context to vendor status (active/inactive)
Bug 39045: Add translation context to course status (active/inactive)
Bug 39045: Add translation context to stock rotation status (active/inactive)
Bug 39045: Add translation context to 'Inactive' as report group
Bug 39045: Add translation context to API key active status
Bug 39045: Add translation context to ERM data providers status (active/inactive)
Bug 39045: Add translation context to fund status (inactive)
Bug 39045: (follow-up) Fix spacing
Bug 39045: Add translation context to currency active status
Bug 39045: Add translation context to budget active status
Bug 39045: Add translation context to course status (active/inactive)
Bug 39045: Add translation context to stock rotation status (active/inactive)
Bug 39045: Add translation context to 'Inactive' as report group
Bug 39045: Add translation context to API key active status
Bug 39045: Add translation context to ERM data providers status (active/inactive)
Bug 39045: Add translation context to fund status (inactive)
Bug 39045: (follow-up) Fix spacing

Description Caroline Cyr La Rose 2025-02-05 19:25:24 UTC
In French, the translations for "Active" and "Inactive" depend on the gender of the thing that is active/inactive. For example, a currency is feminine so it will be active/inactive, but a supplier is masculine so it will be actif/inactif.

I propose to add translation context for "Active" and "Inactive".
Comment 1 Caroline Cyr La Rose 2025-02-05 22:07:15 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2025-02-05 22:07:16 UTC Comment hidden (obsolete)
Comment 3 Caroline Cyr La Rose 2025-02-05 22:07:18 UTC Comment hidden (obsolete)
Comment 4 Caroline Cyr La Rose 2025-02-05 22:07:20 UTC Comment hidden (obsolete)
Comment 5 Caroline Cyr La Rose 2025-02-06 19:05:44 UTC Comment hidden (obsolete)
Comment 6 Caroline Cyr La Rose 2025-02-06 19:21:49 UTC Comment hidden (obsolete)
Comment 7 Caroline Cyr La Rose 2025-02-06 19:38:27 UTC Comment hidden (obsolete)
Comment 8 Caroline Cyr La Rose 2025-02-06 19:51:47 UTC Comment hidden (obsolete)
Comment 9 Caroline Cyr La Rose 2025-02-06 20:05:02 UTC Comment hidden (obsolete)
Comment 10 Caroline Cyr La Rose 2025-02-06 21:38:56 UTC Comment hidden (obsolete)
Comment 11 Caroline Cyr La Rose 2025-02-06 21:54:30 UTC
I only have the booking statuses left, but I can't find out how to make them appear. I can manage 'Pending' and 'Cancelled', but I can never get 'Active'.
Comment 12 Caroline Cyr La Rose 2025-02-06 21:59:23 UTC
All the test plans in one comment

A. Currencies

1. Go to Administration > Currencies and exchange rates
   --> There should be a column with the heading 'Active'
2. Click 'Edit' next to one of the currencies
   --> There should be a field Active:
3. Apply patch
4. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
5. View the fr-CA-messages.po file
   --> There should be entries with 'Currency status' in msgctxt
6. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
7. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
8. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
9. Repeat steps 1 and 2
   --> Translations should be whatever you put in the po file

B. Budgets

1. Go to Acquisitions
   --> In the table under 'All available funds', there should be a column with the heading 'Active'
2. Apply patch
3. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
4. View the fr-CA-messages.po file
   --> There should be an entry with 'Budget status' in msgctxt
5. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
6. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
7. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
8. Repeat step 1
   --> Translation should be whatever you put in the po file

C. Vendors

1. Go to Acquisitions
2. Click 'New vendor'
   --> At the bottom of the form, in the 'Ordering information' section, there should be a choice Vendor is: Active Inactive
3. Enter a vendor name
4. Click 'Save'
5. Click the name of the vendor
   --> In the 'Ordering information' box (bottom left), there should be a mention Vendor is: Active
6. Click 'Edit vendor'
7. Choose 'Inactive'
8. Click 'Save'
   --> Next to the vendor name, it should say '(inactive)'
9. Click the name of the vendor
   --> In the 'Ordering information' box (bottom left), there should be a mention Vendor is: Inactive
10. Apply patch
11. Update translations
    ktd --shell
    gulp po:update --lang fr-CA
12. View the fr-CA-messages.po file
    --> There should be entries with 'Vendor status' in msgctxt
13. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
14. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
    koha-translate --update fr-CA --dev kohadev
15. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
16. Repeat steps 1-9
    --> Translations should be whatever you put in the po file

D. Courses

1. Go to Course reserves
2. Click 'New course'
3. Fill out the mandatory fields
4. Click 'Save'
   --> In the course details, there should be a field Status 'Active'
5. Click 'Edit course'
6. Uncheck 'Enabled?'
7. Click 'Save'
   --> In the course details, there should be a field Status 'Inactive'
8. Apply patch
9. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
10. View the fr-CA-messages.po file
    --> There should be entries with 'Course status' in msgctxt
11. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
12. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
13. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
14. Repeat step 1-7
    --> Translations should be whatever you put in the po file

E. Stock rotation rotas

1. Enable the StockRotation system preference
   1.1. Go to Administration > System preferences
   1.2. Search for StockRotation
   1.3. Choose 'Enable'
   1.4. Click 'Save all Circulation preferences'
2. Go to Cataloging > Stock rotation
3. Click 'New rota'
4. Enter a name for the rota
5. Click 'Save'
   --> There should be a column with the heading 'Active'
6. Click 'Manage' > 'Stages'
7. Click 'Add a stage'
8. Enter a duration
9. Click 'Save'
10. Click 'Return to rotas'
11. Click 'Activate'
12. Click 'Manage' > 'Items'
13. Click 'Add items'
14. Enter a barcode (e.g. 39999000001518)
15. Click 'Save'
16. Click the title of the item
17. Click 'Rota' (left menu)
   --> Under 'Rota status' it should say 'Active'
18. Go back to Cataloging > Stock rotation
19. Click 'Deactivate'
20. Click 'Manage' > 'Items'
21. Click the title of the item
22. Click 'Rota' (left menu)
   --> Under 'Rota status' it should say 'Inactive'
23. Apply patch
24. Update translations
    ktd --shell
    gulp po:update --lang fr-CA
25. View the fr-CA-messages.po file
    --> There should be entries with 'Rota status' in msgctxt
26. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
27. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
28. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
29. Repeat step 1-17
    --> Translations should be whatever you put in the po file

F. Report grouping

1. Go to Reports
   --> There should be an 'Inactive' section heading on the right
2. Click on one of the inactive reports
   --> There should be an 'Inactive' section heading in the left menu
3. Apply patch
4. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
5. View the fr-CA-messages.po file
   --> There should be an entry with 'Group of reports to get inactive patrons and items' in msgctxt
6. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
7. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
8. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
9. Repeat steps 1 and 2
   --> Translations should be whatever you put in the po file

G. API keys

1. Enable the RESTOAuth2ClientCredentials system preference
   1.1. Go to Administration > System preferences
   1.2. Search for RESTOAuth2ClientCredentials
   1.3. Choose 'Enable'
   1.4. Click 'Save all Web services preferences'
2. Click your user name at the top right corner and choose 'My account'
3. Click 'More' > 'Manage API keys'
4. Click 'Generate a new client id/secret pair'
5. Enter a description
6. Click 'Save'
   --> There should be a column with the heading 'Active'
7. Apply patch
8. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
9. View the fr-CA-messages.po file
   --> There should be an entry with 'API client id/key pair status' in msgctxt
10. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
11. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
12. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
13. Repeat step 1-6
    --> Translation should be whatever you put in the po file

H. ERM data providers

1. Enable the ERMModule system preference
   1.1. Go to Administration > System preferences
   1.2. Search for ERMMdoule
   1.3. Choose 'Enable'
   1.4. Click 'Save all E-resource management preferences'
2. Go to E-resource management
3. Click 'Data providers'
4. Click 'New data provider'
   --> There should be a Harvester status field with Active and Inactive options
5. Click 'Create manually'
6. Fill out the mandatory fields
7. Click 'Submit'
   --> There should be a Status field with value 'Active'
8. Click 'Data providers"
   --> The status in the column should be 'Active'
9. Click 'Edit'
10. Change Harvester status to Inactive
11. Click 'Submit'
    --> There should be a Status field with value 'Inactive'
12. Click 'Data providers"
   --> The status in the column should be 'Inactive'
13. Apply patch
14. Update translations
    ktd --shell
    gulp po:update --lang fr-CA
15. View the fr-CA-messages.po file
    --> There should be entries with 'ERM data provider status' in msgctxt
16. Optionally, translate the strings (remember to remove the fuzzy flag, if any)
17. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
18. Enable the new language in Administration > System preferences > StaffInterfaceLanguages
19. Repeat step 1-12
    --> Translations should be whatever you put in the po file
Comment 13 Caroline Cyr La Rose 2025-02-06 22:00:44 UTC
I made a mistake in the ERM data providers test plan, the translations will be in the fr-CA-messages-js.po file, not fr-CA-messages.po.
Comment 14 Jonathan Druart 2025-02-10 13:44:11 UTC
I think we should move the colons out of the strings, to avoid that the translation to appear twice. Unless you have a good argument against that?

+#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt:161
+msgctxt "Currency status"
+msgid "Active: "
+msgstr ""
 
+#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt:241
+#, fuzzy
+msgctxt "Currency status"
+msgid "Active"
+msgstr "Actions"
Comment 15 Jonathan Druart 2025-02-10 13:46:01 UTC
What about this one?

+#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt:120
+#, c-format
+msgid "(inactive)"
+msgstr "(inactif)"
Comment 16 Caroline Cyr La Rose 2025-02-10 15:08:57 UTC
(In reply to Jonathan Druart from comment #14)
> I think we should move the colons out of the strings, to avoid that the
> translation to appear twice. Unless you have a good argument against that?

I don't know if it qualifies as a "good" argument, but in French, typology rules state that there must be a non-breaking space between the word and the colon (e.g. "Active :"). If the colon was not in the string, I don't know how we could do that.
Comment 17 Caroline Cyr La Rose 2025-02-10 20:42:10 UTC Comment hidden (obsolete)
Comment 18 Caroline Cyr La Rose 2025-02-10 20:42:51 UTC
(In reply to Jonathan Druart from comment #15)
> What about this one?
> 
> +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt:120
> +#, c-format
> +msgid "(inactive)"
> +msgstr "(inactif)"

I added a new patch with the (inactive) when used for the fund status
Comment 19 Owen Leonard 2025-03-04 12:15:10 UTC Comment hidden (obsolete)
Comment 20 Owen Leonard 2025-03-04 12:15:19 UTC Comment hidden (obsolete)
Comment 21 Owen Leonard 2025-03-04 12:15:30 UTC Comment hidden (obsolete)
Comment 22 Owen Leonard 2025-03-04 12:15:34 UTC Comment hidden (obsolete)
Comment 23 Owen Leonard 2025-03-04 12:15:36 UTC Comment hidden (obsolete)
Comment 24 Owen Leonard 2025-03-04 12:15:43 UTC Comment hidden (obsolete)
Comment 25 Owen Leonard 2025-03-04 12:15:49 UTC Comment hidden (obsolete)
Comment 26 Owen Leonard 2025-03-04 12:15:57 UTC Comment hidden (obsolete)
Comment 27 Owen Leonard 2025-03-04 12:16:01 UTC Comment hidden (obsolete)
Comment 28 Owen Leonard 2025-03-04 12:16:04 UTC Comment hidden (obsolete)
Comment 29 Lisette Scheer 2025-07-02 16:25:12 UTC
Moving the vendors into vue means this won't apply anymore as one of the patches is trying to update a file that no longer exists.
Comment 30 Owen Leonard 2025-07-02 17:51:59 UTC
Created attachment 183708 [details] [review]
Bug 39045: Add translation context to currency active status

This patch adds translation context to the 'Active' status
for currencies.

To test:
1. Go to Administration > Currencies and exchange rates
   --> There should be a column with the heading 'Active'
2. Click 'Edit' next to one of the currencies
   --> There should be a field Active:
3. Apply patch
4. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
5. View the fr-CA-messages.po file
   --> There should be entries with 'Currency status' in msgctxt
6. Optionally, translate the strings (remember to remove the fuzzy
   flag, if any)
7. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
   koha-translate --update fr-CA --dev kohadev
8. Enable the new language in Administration > System preferences >
   StaffInterfaceLanguages
9. Repeat steps 1 and 2
   --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 31 Owen Leonard 2025-07-02 17:52:02 UTC
Created attachment 183709 [details] [review]
Bug 39045: Add translation context to budget active status

This patch adds translation context to budget active status.

1. Go to Acquisitions
   --> In the table under 'All available funds', there should be a
       column with the heading 'Active'
2. Apply patch
3. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
4. View the fr-CA-messages.po file
   --> There should be an entry with 'Budget status' in msgctxt
5. Optionally, translate the strings (remember to remove the fuzzy flag,
   if any)
6. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
   koha-translate --update fr-CA --dev kohadev
7. Enable the new language in Administration > System preferences >
   StaffInterfaceLanguages
8. Repeat step 1
   --> Translation should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 32 Owen Leonard 2025-07-02 17:52:05 UTC
Created attachment 183710 [details] [review]
Bug 39045: Add translation context to course status (active/inactive)

This patch adds translation context to 'Active' and 'Inactive' when
used as the course status in course reserves.

To test:
1. Go to Course reserves
2. Click 'New course'
3. Fill out the mandatory fields
4. Click 'Save'
   --> In the course details, there should be a field Status 'Active'
5. Click 'Edit course'
6. Uncheck 'Enabled?'
7. Click 'Save'
   --> In the course details, there should be a field Status 'Inactive'
8. Apply patch
9. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
10. View the fr-CA-messages.po file
    --> There should be entries with 'Course status' in msgctxt
11. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
12. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
    koha-translate --update fr-CA --dev kohadev
13. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
14. Repeat step 1-7
    --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 33 Owen Leonard 2025-07-02 17:52:08 UTC
Created attachment 183711 [details] [review]
Bug 39045: Add translation context to stock rotation status (active/inactive)

This patch adds translation context to 'Active' and 'Inactive' when
used as the status of stock rotation rota.

To test:
1. Enable the StockRotation system preference
   1.1. Go to Administration > System preferences
   1.2. Search for StockRotation
   1.3. Choose 'Enable'
   1.4. Click 'Save all Circulation preferences'
2. Go to Cataloging > Stock rotation
3. Click 'New rota'
4. Enter a name for the rota
5. Click 'Save'
   --> There should be a column with the heading 'Active'
6. Click 'Manage' > 'Stages'
7. Click 'Add a stage'
8. Enter a duration
9. Click 'Save'
10. Click 'Return to rotas'
11. Click 'Activate'
12. Click 'Manage' > 'Items'
13. Click 'Add items'
14. Enter a barcode (e.g. 39999000001518)
15. Click 'Save'
16. Click the title of the item
17. Click 'Rota' (left menu)
   --> Under 'Rota status' it should say 'Active'
18. Go back to Cataloging > Stock rotation
19. Click 'Deactivate'
20. Click 'Manage' > 'Items'
21. Click the title of the item
22. Click 'Rota' (left menu)
   --> Under 'Rota status' it should say 'Inactive'
23. Apply patch
24. Update translations
    ktd --shell
    gulp po:update --lang fr-CA
25. View the fr-CA-messages.po file
    --> There should be entries with 'Rota status' in msgctxt
26. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
27. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
28. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
29. Repeat step 1-17
    --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 34 Owen Leonard 2025-07-02 17:52:11 UTC
Created attachment 183712 [details] [review]
Bug 39045: Add translation context to 'Inactive' as report group

This patch adds translation context to the 'Inactive' heading in
reports, to differentiate it from an inactive status of something.

To test:
1. Go to Reports
   --> There should be an 'Inactive' section heading on the right
2. Click on one of the inactive reports
   --> There should be an 'Inactive' section heading in the left menu
3. Apply patch
4. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
5. View the fr-CA-messages.po file
   --> There should be an entry with 'Group of reports to get inactive
       patrons and items' in msgctxt
6. Optionally, translate the strings (remember to remove the fuzzy flag,
   if any)
7. Install new translations
   ktd --root --shell
   koha-translate --install fr-CA --dev kohadev
8. Enable the new language in Administration > System preferences >
   StaffInterfaceLanguages
9. Repeat steps 1 and 2
   --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 35 Owen Leonard 2025-07-02 17:52:14 UTC
Created attachment 183713 [details] [review]
Bug 39045: Add translation context to API key active status

This patch adds translation context to 'Active' and 'Inactive' when
used as the status of an API key.

To test:
1. Enable the RESTOAuth2ClientCredentials system preference
   1.1. Go to Administration > System preferences
   1.2. Search for RESTOAuth2ClientCredentials
   1.3. Choose 'Enable'
   1.4. Click 'Save all Web services preferences'
2. Click your user name at the top right corner and choose 'My account'
3. Click 'More' > 'Manage API keys'
4. Click 'Generate a new client id/secret pair'
5. Enter a description
6. Click 'Save'
   --> There should be a column with the heading 'Active'
7. Apply patch
8. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
9. View the fr-CA-messages.po file
   --> There should be an entry with 'API client id/key pair status' in
       msgctxt
10. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
11. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
12. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
13. Repeat step 1-6
    --> Translation should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 36 Owen Leonard 2025-07-02 17:52:17 UTC
Created attachment 183714 [details] [review]
Bug 39045: Add translation context to ERM data providers status (active/inactive)

This patch adds translation context to 'Active' and 'Inactive' when
used as the status of ERM data providers.

This patch needs the patch in bug 39061 in order to work properly.

To test:
1. Enable the ERMModule system preference
   1.1. Go to Administration > System preferences
   1.2. Search for ERMMdoule
   1.3. Choose 'Enable'
   1.4. Click 'Save all E-resource management preferences'
2. Go to E-resource management
3. Click 'Data providers'
4. Click 'New data provider'
   --> There should be a Harvester status field with Active and
       Inactive options
5. Click 'Create manually'
6. Fill out the mandatory fields
7. Click 'Submit'
   --> There should be a Status field with value 'Active'
8. Click 'Data providers"
   --> The status in the column should be 'Active'
9. Click 'Edit'
10. Change Harvester status to Inactive
11. Click 'Submit'
    --> There should be a Status field with value 'Inactive'
12. Click 'Data providers"
   --> The status in the column should be 'Inactive'
13. Apply patch
14. Update translations
    ktd --shell
    gulp po:update --lang fr-CA
15. View the fr-CA-messages.po file
    --> There should be entries with 'ERM data provider status' in
        msgctxt
16. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
17. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
18. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
19. Repeat step 1-12
    --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 37 Owen Leonard 2025-07-02 17:52:20 UTC
Created attachment 183715 [details] [review]
Bug 39045: Add translation context to fund status (inactive)

This patch adds translation context to '(inactive)' when used for the
fund status in acquisitions.

To test:

1. Create an inactive budget and fund
   1.1. Go to Administration > Budgets
   1.2. Click 'New budget'
   1.3. Fill out the mandatory fields and the total amount, DO NOT
        check the 'Make budget active' box
   1.4. Click 'Save'
   1.5. Click 'Inactive budgets'
   1.6. Next to the new budget, click 'Actions' > 'Add fund'
   1.7. Fill out the mandatory fields
   1.8. Click 'Submit'

2. Create a suggestion and link it to an inactive fund
   2.1. Go to Acquisitions > Suggestions
   2.2. Click 'New purchase suggestion'
   2.3. Fill out the title
   2.4. Under 'Acquisition information', check 'Show inactive'
   2.5. Open the 'Fund' dropdown
        --> There should be your new fund with (inactive) next to it
   2.6. Choose the inactive fund
   2.7. Click 'Submit your suggestion'

3. Create an order from new file, link it to an inactive fund
   3.1. Go to Acquisitions
   3.2. Click 'Search' under 'Search vendors'
   3.3. Click 'Add to basket' next to 'My basket'
   3.4. Click 'From a new file'
   3.5. Choose a MARC file (I attached an example if necessary)
   3.6. Click 'Upload file'
   3.7. Click 'Stage for import'
   3.8. Click 'Add staged files to basket'
   3.9. Click 'Default accounting details'
   3.10. Check 'Show inactive' next to the fund dropdown
   3.11. Open the 'Fund' dropdown
         --> There should be your new fund with (inactive) next to it
   3.12. Choose the inactive fund
   3.13. Click 'Item information'
   3.14. Fill out the 'y - Koha item type' field
   3.15. Click 'Select to import'
   3.16. Check the 'Show inactive funds' box
   3.17. Check the box next to the record
   3.18. Open the 'Fund' dropdown
         --> There should be your new fund with (inactive) next to it
   3.19. Enter a price
   3.20. Click 'Save'

**Note: there are 5 occurrences of "(inactive)" in that page, but I only
  found those two...**

4. Create a duplicate order
   4.1. Click 'Add to basket'
   4.2. Click 'From existing orders (copy)'
   4.3. Search for the previous order
   4.4. Check the box next to the order
   4.5. Click 'Next ->'
   4.6. Check 'Show inactive' next to the fund dropdown
   4.7. Open the 'Fund' dropdown
        --> There should be your new fund with (inactive) next to it
   4.8. Choose the inactive fund
   4.9. Click 'Duplicate orders'

5. Create an order from an empty record
   5.1. Click 'Add to basket'
   5.2. Click 'From a new (empty) record'
   5.3. Fill out catalog details (at least the title)
   5.4. Fill out the 'y - Koha item type' field
   5.5. Check 'Show inactive' next to the fund dropdown
   5.6. Open the 'Fund' dropdown
        --> There should be your new fund with (inactive) next to it
   5.7. Choose the inactive fund
   5.8. Enter a vendor price
   5.9. Click 'Save'

6. Close the basket and receive the orders
   6.1. Click 'Close basket'
   6.2. Click 'Yes, close (Y)'
   6.3. Click 'Receive shipments'
   6.4. Enter a vendor invoice number
   6.5. Check 'Show inactive'
   6.6. Open the 'Fund' dropdown
        --> There should be your new fund with (inactive) next to it
   6.7. Click 'Next'
   6.8. Click 'Receive' next to an order
   6.9. Check 'Show inactive'
   6.10. Open the 'Fund' dropdown
         --> There should be your budget with (Inactive) next to it
         --> There should be your new fund with (inactive) next to it
   6.11. Choose the inactive fund
   6.12. Check 'Receive?'
   6.13. Click 'Confirm'
   6.14. Click 'Finish receiving'
   6.15. Click 'Show inactive' next to 'Shipping fund'
         --> There should be your new fund with (inactive) next to it

7. View Orders by fund report
   7.1. Go to Reports > Orders by fund
   7.2. Check 'Show inactive'
   7.3. Open the 'Fund' dropdown
        --> There should be your new fund with (inactive) next to it

8. Apply patch
9. Update translations
   ktd --shell
   gulp po:update --lang fr-CA
10. View the fr-CA-messages.po file
    --> There should be entries with 'Fund status' and one entry with
    'Budget status' in msgctxt
11. Optionally, translate the strings (remember to remove the fuzzy
    flag, if any)
12. Install new translations
    ktd --root --shell
    koha-translate --install fr-CA --dev kohadev
13. Enable the new language in Administration > System preferences >
    StaffInterfaceLanguages
14. Repeat steps 1-7
    --> Translations should be whatever you put in the po file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 38 Owen Leonard 2025-07-02 17:52:25 UTC
Created attachment 183716 [details] [review]
Bug 39045: (follow-up) Fix spacing

Adding some whitespace to the markup so that the "(inactive)" has a
space before it.
Comment 39 Owen Leonard 2025-07-02 17:55:08 UTC
(In reply to Lisette Scheer from comment #29)
> Moving the vendors into vue means this won't apply anymore as one of the
> patches is trying to update a file that no longer exists.

I've rebased and re-attached the patches without the vendors one