Bug 39050

Summary: Duplicate "type" attributes in ill-batch-modal.inc
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ILLAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: minor    
Priority: P5 - low CC: pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 30719    
Bug Blocks:    
Attachments: Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc

Description Owen Leonard 2025-02-06 13:23:50 UTC
There are a couple of input tags in ill-batch-modal.inc which have duplicate "type" attributes.
Comment 1 Owen Leonard 2025-02-06 13:36:08 UTC
Created attachment 177571 [details] [review]
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc

This patch removes duplicate "type" attributes from two inputs in
ill-batch-modal.inc.

I don't know how to test this, but a visual inspection of the changes
should be enough.
Comment 2 Magnus Enger 2025-02-07 07:05:14 UTC
Created attachment 177609 [details] [review]
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc

This patch removes duplicate "type" attributes from two inputs in
ill-batch-modal.inc.

I don't know how to test this, but a visual inspection of the changes
should be enough.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense
Comment 3 Nick Clemens (kidclamp) 2025-02-07 14:50:44 UTC
Created attachment 177631 [details] [review]
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc

This patch removes duplicate "type" attributes from two inputs in
ill-batch-modal.inc.

I don't know how to test this, but a visual inspection of the changes
should be enough.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Owen Leonard 2025-02-12 14:51:47 UTC
Created attachment 177927 [details] [review]
Bug 39050: Duplicate "type" attributes in ill-batch-modal.inc

This patch removes duplicate "type" attributes from two inputs in
ill-batch-modal.inc.

I don't know how to test this, but a visual inspection of the changes
should be enough.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Makes sense
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2025-02-13 15:20:37 UTC
Pushed for 25.05!

Well done everyone, thank you!