Summary: | Item search returns error | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Bug Depends on: | 38664 | ||
Bug Blocks: | |||
Attachments: |
Bug 39112: Fix item search results error
Bug 39112: Fix item search results error Bug 39112: Fix item search results error Bug 39112: Force the response on a single line |
Description
Caroline Cyr La Rose
2025-02-12 16:30:24 UTC
Created attachment 177952 [details] [review] Bug 39112: Fix item search results error This patch updates the template which generates item search JSON (for use by the DataTable) to add a 'collapse' FILTER around it. This eliminates whitespace which causes the JSON to be invalid. To test, apply the patch and perform an item search in the staff interface. It should return results without error. Sponsored-by: Athens County Public Libraries Created attachment 177953 [details] [review] Bug 39112: Fix item search results error This patch updates the template which generates item search JSON (for use by the DataTable) to add a 'collapse' FILTER around it. This eliminates whitespace which causes the JSON to be invalid. To test, apply the patch and perform an item search in the staff interface. It should return results without error. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thank you Owen! wondering if we don't have more then, see bug 39087 Created attachment 177973 [details] [review] Bug 39112: Fix item search results error This patch updates the template which generates item search JSON (for use by the DataTable) to add a 'collapse' FILTER around it. This eliminates whitespace which causes the JSON to be invalid. To test, apply the patch and perform an item search in the staff interface. It should return results without error. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 177974 [details] [review] Bug 39112: Force the response on a single line We don't need an empty blank line. Might not have been caused by the tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 25.05! Well done everyone, thank you! |