| Summary: | xt/js_tidy.t and xt/vue_tidy.t does not use tidy.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
25.05.00
|
Circulation function: | |
| Bug Depends on: | 38664 | ||
| Bug Blocks: | 39115 | ||
| Attachments: |
Bug 39119: Make js_tidy and vue_tidy test use the tidy script
Bug 39119: Make js_tidy and vue_tidy test use the tidy script Bug 39119: Make js_tidy and vue_tidy test use the tidy script |
||
|
Description
Jonathan Druart
2025-02-13 08:18:08 UTC
Created attachment 177983 [details] [review] Bug 39119: Make js_tidy and vue_tidy test use the tidy script They were still using prettier directly. They should use the tidy.pl as it is doing some wrapper work. Created attachment 177987 [details] [review] Bug 39119: Make js_tidy and vue_tidy test use the tidy script They were still using prettier directly. They should use the tidy.pl as it is doing some wrapper work. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. prove xt/js_tidy.t passes before and after the the patch. Thanks David! Created attachment 178025 [details] [review] Bug 39119: Make js_tidy and vue_tidy test use the tidy script They were still using prettier directly. They should use the tidy.pl as it is doing some wrapper work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! Enhancement not pushed to 24.11.x Changes to test suite, no changes to the manual required. |