Bug 39119

Summary: xt/js_tidy.t and xt/vue_tidy.t does not use tidy.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: enhancement    
Priority: P5 - low CC: david
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 38664    
Bug Blocks: 39115    
Attachments: Bug 39119: Make js_tidy and vue_tidy test use the tidy script
Bug 39119: Make js_tidy and vue_tidy test use the tidy script
Bug 39119: Make js_tidy and vue_tidy test use the tidy script

Description Jonathan Druart 2025-02-13 08:18:08 UTC
They are still using `prettier` directly.
Comment 1 Jonathan Druart 2025-02-13 08:21:32 UTC
Created attachment 177983 [details] [review]
Bug 39119: Make js_tidy and vue_tidy test use the tidy script

They were still using prettier directly. They should use the tidy.pl as
it is doing some wrapper work.
Comment 2 David Nind 2025-02-13 09:22:53 UTC
Created attachment 177987 [details] [review]
Bug 39119: Make js_tidy and vue_tidy test use the tidy script

They were still using prettier directly. They should use the tidy.pl as
it is doing some wrapper work.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-02-13 09:23:29 UTC
Testing notes (using KTD):

1. prove xt/js_tidy.t passes before and after the the patch.
Comment 4 Katrin Fischer 2025-02-13 10:22:59 UTC
Thanks David!
Comment 5 Nick Clemens (kidclamp) 2025-02-13 15:31:11 UTC
Created attachment 178025 [details] [review]
Bug 39119: Make js_tidy and vue_tidy test use the tidy script

They were still using prettier directly. They should use the tidy.pl as
it is doing some wrapper work.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Katrin Fischer 2025-02-13 16:15:29 UTC
Pushed for 25.05!

Well done everyone, thank you!