Bug 39126

Summary: The tidy script might hide useful error message
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Julian Maurice <julian.maurice>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 38664    
Bug Blocks:    
Attachments: Bug 39126: tidy - Show error if stderr_buf is empty
Bug 39126: tidy - Show error if stderr_buf is empty

Description Jonathan Druart 2025-02-13 11:56:15 UTC

    
Comment 1 Jonathan Druart 2025-02-13 11:58:23 UTC
Created attachment 177991 [details] [review]
Bug 39126: tidy - Show error if stderr_buf is empty

If yarn is not installed:
Tidying file 1/1 (koha-tmpl/intranet-tmpl/prog/fr-FR/modules/intranet-main.tt)
Warning: something's wrong at misc/devel/tidy.pl line 79.

There is the error hidden in $error_message
open3: exec of yarn --silent run prettier --write koha-tmpl/intranet-tmpl/prog/fr-FR/modules/intranet-main.tt failed: No such file or directory
Comment 2 Julian Maurice 2025-02-13 12:37:52 UTC
Created attachment 177992 [details] [review]
Bug 39126: tidy - Show error if stderr_buf is empty

If yarn is not installed:
Tidying file 1/1 (koha-tmpl/intranet-tmpl/prog/fr-FR/modules/intranet-main.tt)
Warning: something's wrong at misc/devel/tidy.pl line 79.

There is the error hidden in $error_message
open3: exec of yarn --silent run prettier --write koha-tmpl/intranet-tmpl/prog/fr-FR/modules/intranet-main.tt failed: No such file or directory

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 3 Katrin Fischer 2025-02-13 14:32:50 UTC
Pushed for 25.05!

Well done everyone, thank you!