Description
Shi Yao Wang
2025-02-18 14:26:39 UTC
Created attachment 178274 [details] [review] Bug 39156: Add hooks before and after batch on authority/biblio/item Useful to dump marc files after batch operation for example Created attachment 178790 [details] [review] Bug 39156: Add missing hooks in MARCImportRevertBatch Created attachment 180079 [details] [review] Bug 39156: Add hooks before and after batch on authority/biblio/item Useful to dump marc files after batch operation for example Created attachment 180080 [details] [review] Bug 39156: Add missing hooks in MARCImportRevertBatch Created attachment 180081 [details] [review] Bug 39156: Unit test Test plan: 1- Apply the patch 2- run `prove t/db_dependent/Koha/Plugins/Biblio_and_items_plugin_hooks.t` 3- Tests should pass Created attachment 180219 [details] [review] Bug 39156: Add hooks before and after batch on authority/biblio/item Useful to dump marc files after batch operation for example Created attachment 180220 [details] [review] Bug 39156: Add missing hooks in MARCImportRevertBatch Created attachment 180221 [details] [review] Bug 39156: Unit test Test plan: 1- Apply the patch 2- run `prove t/db_dependent/Koha/Plugins/Batch_plugin_hooks.t` 3- Tests should pass Hi, Could you perhaps add an action parameter to the call (so the plugin knows which kind of action was performed or is going to be performed) ? Something similar to what what done for: - Bug 27173 - Add plugin hooks for authority record changes or - Bug 27066 - Implement hooks for patrons updates Created attachment 180422 [details] [review] Bug 39156: Pass batch action to the hooks + refactoring (In reply to Matthias Meusburger from comment #9) > Hi, > > Could you perhaps add an action parameter to the call (so the plugin knows > which kind of action was performed or is going to be performed) ? > > Something similar to what what done for: > > - Bug 27173 - Add plugin hooks for authority record changes > or > - Bug 27066 - Implement hooks for patrons updates I added an action parameter. I hope they are descriptive enough :) Ok, thanks, works for me, I'm signing this off. Created attachment 180428 [details] [review] Bug 39156: Add hooks before and after batch on authority/biblio/item Useful to dump marc files after batch operation for example Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 180429 [details] [review] Bug 39156: Add missing hooks in MARCImportRevertBatch Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 180430 [details] [review] Bug 39156: Unit test Test plan: 1- Apply the patch 2- run `prove t/db_dependent/Koha/Plugins/Batch_plugin_hooks.t` 3- Tests should pass Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 180431 [details] [review] Bug 39156: Pass batch action to the hooks + refactoring Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> |