Summary: | Batch Modify tool overwrites dropdown fields - no option for "no change" | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Tools | Assignee: | Sophie MEYNIEUX <sophie.meynieux> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | P2 | CC: | f.demians, gmcharlt, henridamien, koha.sekjal, oleonard, paul.poulain, sophie.meynieux, wizzyrea |
Version: | 3.6 | ||
Hardware: | PC | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/batchMod.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
patch proposed for branches.
Adding default empty value on ALL pull do lists [Signed Off] Bug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branches, to let the corresponding value unchanged |
Description
Chris Cormack
2010-05-21 01:20:58 UTC
upgrading again because you cannot use this tool as it stands - which I believe is the definition of a blocker. If I want to edit items in multiple branches this tool will change the branch on all of the items to the same branch because there is no blank default for that field. You are right. I am working on that at the moment. Fact is that it is linked to GetBranchesLoop which returns selected on the user branch... Which in that case is NOT what user expects. Created attachment 2263 [details] [review] patch proposed for branches. Patch pushed. Please test and close. There is still one pull down left - the classification scheme and then we're all set. (In reply to comment #5) > There is still one pull down left - the classification scheme and then we're > all set. Pushed fix for this. Please test and close. Tested, this has been resolved. Will add a new enhancement bug to note the fact that you can't "unset" values using this tool (example: lost to NOT LOST). Proposing a follow-up in order that ALL fields with pull down have an empty value selected as the default, even if the field is mandatory. Created attachment 7650 [details] [review] Adding default empty value on ALL pull do lists Sophie, Doesn't the checkbox serve the same purpose? Is there an additional use case that makes this new patch necessary? Liz The patch works, btw, I'll sign off on it but I'm not certain it's strictly *necessary*. Feel free to convince me. :) Created attachment 7669 [details] [review] [Signed Off] Bug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branches, to let the corresponding value unchanged Signed-off-by: Liz Rea <wizzyrea@gmail.com> Patch works as advertised I second Liz's request for clarification on the necessity of this change. (In reply to comment #10) > Sophie, > > Doesn't the checkbox serve the same purpose? Not at all !!! the checkbox are here to force *emptying* the subfield. The doc says: "Checking the box right next the subfield label will disable the entry and delete the values of that subfield on all selected items" The "empty value" in other lists means "don't change anything to the existing value" > Is there an additional use case > that makes this new patch necessary? Switching back to signed-off. If you agree with my explanatin, you can mark as "passed QA" because it's a small patch, nothing to say. Then i'll push it. (not pushing it immediatly just to double check everything is OK with the behaviour) Paul, Thanks for the clarification, that clears up what I needed to pass this patch through QA (it's a simple patch with little chance of any regressions anywhere). This patch will be in 3.6.5 (no string changes). |