Summary: | Acquisitions homepage no longer automatically hides "active" and "budget period" columns | ||
---|---|---|---|
Product: | Koha | Reporter: | Todd Goatley <tgoatley> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, m.de.rooy, oleonard |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Bug Depends on: | 36640 | ||
Bug Blocks: | |||
Attachments: |
Budget screen shot with columns at issue
Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page |
Prior to 24.11, the funds table on the acq homepage automatically hid its first two columns. The code to do so is still present, but is no longer working: https://github.com/Koha-Community/Koha/blob/cc0aa072dd5c1c0cb664ce6ffde43abe09d94fac/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt#L246 Since these columns are meant to be hardcoded as hidden, they're disabled in Table Settings. That means that now they're showing and cannot be toggled to not-show. Created attachment 178411 [details] [review] Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. Created attachment 178412 [details] [review] Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Created attachment 178452 [details] [review] Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! |
Created attachment 178369 [details] Budget screen shot with columns at issue HI Koha Dev's! The Acquisitions home page is displaying two columns that should be hidden by default (see screenshot) The first column is 'Active' and the second is 'Budget period description.' I don't think they were displayed previous to 24.11. Plus the the info is distracting, clutters up the display and is not useful. I checked the column settings to see if I could hide them but the 'Is hidden by default' setting is greyed out but not checked. The 'Cannot be toggled' setting is both greyed out and checked. (Submitted on behalf of Barbara at Bedford Public Library in Bedford Texas) Cheers! Todd