Bug 39177

Summary: Add additional fields support to credit types
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Point of SaleAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: aude.charillon, brendan, daniel.jones, fiona.borthwick, hdunne-howrie, lucas, martin.renvoize, pedro.amorim, sally.healey, testopia
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 38457    
Bug Blocks:    
Attachments: Bug 39177: DBIC Add AdditionalFields to AccountCreditType
Bug 39177: Add additional fields to credit types
Bug 39177: DBIC Add AdditionalFields to AccountCreditType
Bug 39177: Add additional fields to credit types
Bug 39177: DBIC Add AdditionalFields to AccountCreditType
Bug 39177: Add additional fields to credit types

Description Martin Renvoize (ashimema) 2025-02-20 12:43:56 UTC
A parallel bug to bug 38457 to have additional field support for credit types.
Comment 1 Martin Renvoize (ashimema) 2025-02-20 13:09:02 UTC
Created attachment 178409 [details] [review]
Bug 39177: DBIC Add AdditionalFields to AccountCreditType

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Comment 2 Martin Renvoize (ashimema) 2025-02-20 13:09:04 UTC
Created attachment 178410 [details] [review]
Bug 39177: Add additional fields to credit types

Test plan, k-t-d:
1) Before defining any additional fields for account_credit_types,
   confirm that the 'Additional fields' section does not appear when
   attempting to add a new or edit an existing credit type.
2) Add a new additional field to 'account_credit_types':
   <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_credit_types
3) Click 'New field'. Add a name. Click Save.
4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category
   (one repeatable, one not repeatable)
5) Edit an account credit type:
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL
6) Input various values in the different additional fields. Click
   'Submit'
7) Edit the same credit type again and note the additional fields added
   in the previous step are visible
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Comment 3 Brendan Gallagher 2025-04-03 09:41:33 UTC
Needs a quick rebase (sorry!!)
Comment 4 Martin Renvoize (ashimema) 2025-04-03 12:16:23 UTC
Created attachment 180499 [details] [review]
Bug 39177: DBIC Add AdditionalFields to AccountCreditType

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2025-04-03 12:16:27 UTC
Created attachment 180500 [details] [review]
Bug 39177: Add additional fields to credit types

Test plan, k-t-d:
1) Before defining any additional fields for account_credit_types,
   confirm that the 'Additional fields' section does not appear when
   attempting to add a new or edit an existing credit type.
2) Add a new additional field to 'account_credit_types':
   <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_credit_types
3) Click 'New field'. Add a name. Click Save.
4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category
   (one repeatable, one not repeatable)
5) Edit an account credit type:
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL
6) Input various values in the different additional fields. Click
   'Submit'
7) Edit the same credit type again and note the additional fields added
   in the previous step are visible
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Comment 6 Brendan Gallagher 2025-04-03 12:31:04 UTC
Created attachment 180501 [details] [review]
Bug 39177: DBIC Add AdditionalFields to AccountCreditType

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 7 Brendan Gallagher 2025-04-03 12:31:07 UTC
Created attachment 180502 [details] [review]
Bug 39177: Add additional fields to credit types

Test plan, k-t-d:
1) Before defining any additional fields for account_credit_types,
   confirm that the 'Additional fields' section does not appear when
   attempting to add a new or edit an existing credit type.
2) Add a new additional field to 'account_credit_types':
   <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_credit_types
3) Click 'New field'. Add a name. Click Save.
4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category
   (one repeatable, one not repeatable)
5) Edit an account credit type:
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL
6) Input various values in the different additional fields. Click
   'Submit'
7) Edit the same credit type again and note the additional fields added
   in the previous step are visible
   <staff_url>/cgi-bin/koha/admin/credit_types.pl?op=add_form&code=MANUAL

Sponsored-by: PTFS Europe <https://ptfs-europe.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-04-29 15:54:00 UTC
Small rebase needed here.