Bug 39178

Summary: ILL table does not render when viewing requests of a batch
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: jeremy.evans, katrin.fischer, m.de.rooy, martin.renvoize, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 38714    
Bug Blocks:    
Attachments: Bug 39178: Fix table naming
Bug 39178: Fix table naming
Bug 39178: Fix table naming

Description Pedro Amorim 2025-02-20 12:49:43 UTC
To test:
1) Enabled ILLModule
2) Install a metadat enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) No table is rendered

Caused by:
https://github.com/Koha-Community/Koha/commit/7219566
Comment 1 Pedro Amorim 2025-02-20 12:50:52 UTC
Created attachment 178405 [details] [review]
Bug 39178: Fix table naming

To test:
1) Enabled ILLModule
2) Install a metadat enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) No table is rendered
11) Apply patch. Repeat.
Comment 2 Owen Leonard 2025-02-20 13:33:44 UTC
Created attachment 178413 [details] [review]
Bug 39178: Fix table naming

To test:
1) Enabled ILLModule
2) Install a metadat enrichment plugin .e.g:
   https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
   http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the
   right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) No table is rendered
11) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-02-21 09:15:58 UTC
Created attachment 178453 [details] [review]
Bug 39178: Fix table naming

To test:
1) Enabled ILLModule
2) Install a metadat enrichment plugin .e.g:
   https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
   http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the
   right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) No table is rendered
11) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2025-02-21 15:45:15 UTC
Pushed for 25.05!

Well done everyone, thank you!