Bug 39179

Summary: ILL batches should allow editing without having to add new requests
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jeremy.evans, katrin.fischer, martin.renvoize, pedro.amorim, tomascohen
Version: 24.11Keywords: release-notes-needed
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39179: Update batches table icons
Bug 39179: Update style of 'remove' button when adding requests to batch
Bug 39179: CSS and layout adjustments:
Bug 39179: Adjust modal buttons visibility
Bug 39179: Allow edit batch without having to add new items
Bug 39179: Update batches table icons
Bug 39179: Update style of 'remove' button when adding requests to batch
Bug 39179: CSS and layout adjustments:
Bug 39179: Adjust modal buttons visibility
Bug 39179: Allow edit batch without having to add new items
Bug 39179: Update batches table icons
Bug 39179: Update style of 'remove' button when adding requests to batch
Bug 39179: CSS and layout adjustments:
Bug 39179: Adjust modal buttons visibility
Bug 39179: Allow edit batch without having to add new items

Description Pedro Amorim 2025-02-20 16:22:58 UTC

    
Comment 1 Pedro Amorim 2025-02-20 16:58:16 UTC
Created attachment 178433 [details] [review]
Bug 39179: Update batches table icons
Comment 2 Pedro Amorim 2025-02-20 16:58:18 UTC
Created attachment 178434 [details] [review]
Bug 39179: Update style of 'remove' button when adding requests to batch
Comment 3 Pedro Amorim 2025-02-20 16:58:20 UTC
Created attachment 178435 [details] [review]
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.
Comment 4 Pedro Amorim 2025-02-20 16:58:23 UTC
Created attachment 178436 [details] [review]
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden
Comment 5 Pedro Amorim 2025-02-20 16:58:26 UTC
Created attachment 178437 [details] [review]
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit the batch name or library or status and click 'Finish and view batch'. Notice it saves the batch.
Comment 6 Pedro Amorim 2025-02-28 15:48:26 UTC
Created attachment 178853 [details] [review]
Bug 39179: Update batches table icons

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 7 Pedro Amorim 2025-02-28 15:48:29 UTC
Created attachment 178854 [details] [review]
Bug 39179: Update style of 'remove' button when adding requests to batch

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 8 Pedro Amorim 2025-02-28 15:48:31 UTC
Created attachment 178855 [details] [review]
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 9 Pedro Amorim 2025-02-28 15:48:34 UTC
Created attachment 178856 [details] [review]
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 10 Pedro Amorim 2025-02-28 15:48:36 UTC
Created attachment 178857 [details] [review]
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit the batch name or library or status and click 'Finish and view batch'. Notice it saves the batch.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 11 Tomás Cohen Arazi (tcohen) 2025-05-08 20:02:34 UTC
Created attachment 182113 [details] [review]
Bug 39179: Update batches table icons

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 12 Tomás Cohen Arazi (tcohen) 2025-05-08 20:02:37 UTC
Created attachment 182114 [details] [review]
Bug 39179: Update style of 'remove' button when adding requests to batch

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 13 Tomás Cohen Arazi (tcohen) 2025-05-08 20:02:39 UTC
Created attachment 182115 [details] [review]
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 14 Tomás Cohen Arazi (tcohen) 2025-05-08 20:02:42 UTC
Created attachment 182116 [details] [review]
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 15 Tomás Cohen Arazi (tcohen) 2025-05-08 20:02:45 UTC
Created attachment 182117 [details] [review]
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit the batch name or library or status and click 'Finish and view batch'. Notice it saves the batch.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 16 Katrin Fischer 2025-05-09 07:14:02 UTC
Pushed for 25.05!

Well done everyone, thank you!