Summary: | Self checkout: Fix ugly error on wrong password when logging in | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Self checkout | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the error message on the self checkout login form (when the AutoSelfCheckAllowed system preference is used) so that it uses the same message as the regular OPAC when incorrect credentials are used.
- Previous message: "The userid Koha::Patron=HASH(0x606447f6d868) was not found in the database. Please try again."
- Updated error message: "You entered an incorrect username or password. Please try again! But note that passwords are case sensitive. Please contact a library staff member if you continue to have problems."
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 39217: Fix ugly error on wrong password in SCO login
Bug 39217: Fix ugly error on wrong password in SCO login Bug 39217: Fix ugly error on wrong password in SCO login Bug 39217: (follow-up) Break up text to improve spacing after tidy Bug 39217: Fix ugly error on wrong password in SCO login Bug 39217: (follow-up) Break up text to improve spacing after tidy |
Description
Magnus Enger
2025-02-28 14:50:09 UTC
Created attachment 178870 [details] [review] Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Created attachment 179419 [details] [review] Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 179564 [details] [review] Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Hm, this is not tidy in my environment. Please check your tools! :) (In reply to Katrin Fischer from comment #4) > Hm, this is not tidy in my environment. Please check your tools! :) Hm when I tidy, I have this: >You entered an incorrect username or password. Please try again! But note that passwords are case - sensitive[% IF Koha.Preference('FailedLoginAttempts') %]and that your account will be locked out after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you + sensitive[% IF Koha.Preference('FailedLoginAttempts') %]and that your account will be locked after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you continue to have problems.</p And it defintiely feels lke the space before the and should have been kept. But: this is a bit of a translation issue overall. We should not "puzzle" sentences ideally. Leaving for Joubu to take a look. Created attachment 179683 [details] [review] Bug 39217: (follow-up) Break up text to improve spacing after tidy Please rebase! Created attachment 181032 [details] [review] Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 181033 [details] [review] Bug 39217: (follow-up) Break up text to improve spacing after tidy Pushed for 25.05! Well done everyone, thank you! |