Bug 3924

Summary:	useDaysMode problems in french and improve needs
Product:	Koha	Reporter:	Nahuel Angelinetti <nahuel.angelinetti>
Component:	Circulation	Assignee:	Guillaume Hatt <guillaume>
Status:	CLOSED INVALID	QA Contact:	Bugs List <koha-bugs>
Severity:	minor
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, dev_patches, guillaume, julian.maurice, paul.poulain
Version:	3.4
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	5992
Attachments:	Patch for 3.4 [SIGNED-OFF] (bug #3924 MT2500) fix useDaysMode use [SIGNED-OFF] (bug #3924 MT2500) fix useDaysMode use

Description Chris Cormack 2010-05-21 01:21:04 UTC



---- Reported by nahuel.angelinetti@biblibre.com 2009-12-15 10:21:58 ----

useDaysMode syspref is well managed, but some code is repeated, and the frenchsyspref is badly set.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3924 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3924

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2010-06-29 18:06:18 UTC

I see that this fix was pushed to branch 3.0.x on 2009-12-17 so I've marked
this as a rel_3_0 bug.

Comment 2 Paul Poulain 2011-02-22 12:37:59 UTC

can't find the patch by bugzilla number, title, and don't know in which script. Owen or chris any idea ?

Comment 3 Owen Leonard 2011-02-22 16:12:37 UTC

On the patches list:

http://lists.koha-community.org/pipermail/koha-patches/2009-December/010608.html

On the commits list (committed to 3.0.x):

http://lists.koha-community.org/pipermail/koha-commits/2009-December/000977.html

Comment 4 Chris Cormack 2011-03-29 21:24:54 UTC

New patch attached for 3.4

Comment 5 Chris Cormack 2011-03-29 21:25:27 UTC Comment hidden (obsolete)

Created attachment 3509 [details] [review]
Patch for 3.4

Comment 6 dev_patches 2011-04-04 15:05:41 UTC

Does not apply because of updatedatabase and kohaversion. 
But should be ok to push.

Comment 7 Katrin Fischer 2011-06-01 05:23:11 UTC Comment hidden (obsolete)

Created attachment 4324 [details] [review]
[SIGNED-OFF] (bug #3924 MT2500) fix useDaysMode use

This fix system preference choices, and delete some useless code.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fix is for fr-FR sql file. All other langages correctly include all 3
possible options for useDaysMode.
The patch also includes a database update.

Comment 8 Katrin Fischer 2011-06-01 05:23:26 UTC

Created attachment 4325 [details] [review]
[SIGNED-OFF] (bug #3924 MT2500) fix useDaysMode use

This fix system preference choices, and delete some useless code.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fix is for fr-FR sql file. All other langages correctly include all 3
possible options for useDaysMode.
The patch also includes a database update.

Comment 9 Paul Poulain 2011-08-02 16:15:41 UTC

irrelevant with the new systempreferences management : the list is not built from systempreferences table but from .pref file