Bug 3926

Summary: Managing suggestions: suggestion edit form combines data
Product: Koha Reporter: Owen Leonard <oleonard>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Proposed fix
Additional fix

Description Chris Cormack 2010-05-21 01:21:05 UTC


---- Reported by oleonard@myacpl.org 2009-12-15 14:14:22 ----

When editing a suggestion (suggestion/suggestion.pl?op=add) information is displayed about when the suggestion was managed. This information is passed to the template as one variable even though it consists of several individual elements:

my $presentation_string=$$member{firstname}." ".$$member{surname}." ".GetBranchName($$member{branchcode})." ".$$member{description}." ".$$member{category_type};

It would be better to pass each element to the template so that the display was more flexible.



---- Additional Comments From oleonard@myacpl.org 2009-12-15 18:16:09 ----

Created an attachment
Proposed fix





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3926 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3926
Imported an attachment (id=1690)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1690 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-06-03 15:14:29 UTC
Created attachment 2211 [details] [review]
Additional fix

The template-side fix for this bug was overwritten by another template change I submitted later. My bad.
Comment 2 Galen Charlton 2010-06-04 00:45:02 UTC
Patch pushed.  Please test and close.