Bug 39290

Summary: Always use pageLength=-1 when paginate is false
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39289    
Bug Blocks:    

Description Jonathan Druart 2025-03-10 15:26:32 UTC
On bug 39289 I noticed that we pass more than 20 checkouts to the template but only 20 are displayed because we have DataTable's pageLength:20 and paginate:false.

Should we always have pageLength set to -1 when paginate is turned off?

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt:                        paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt:                       paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:                        paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:                        paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfers_to_send.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:                    paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt:              paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt:              paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt:                paginate: false,
koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js:        paginate: false,
Comment 1 Jonathan Druart 2025-03-10 15:32:53 UTC
Is it only relevant when `dom: "t"`?

reports/itemslost.tt
```
            var lostitems_table = $("#lostitems-table").kohaTable(
                {
                    order: [], 
                    columnDefs: [
                        { orderable: false, searchable: false, targets: ["NoSort"] },
                    ],
                    autoWidth: false,
                    paginate: false,
                },
                table_settings,
                "with_filters"
            );
```

Pagination is shown and working.