Summary: | `perl -cw` should pass on all Perl files | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | emily.lamancusa, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 39325, 39324 | ||
Attachments: |
Bug 39365: Add tests
Bug 39365: Fix 3 files Bug 39365: Add tests Bug 39365: Fix 3 files Bug 39365: Add tests Bug 39365: Fix 3 files |
Description
Jonathan Druart
2025-03-18 11:12:34 UTC
Created attachment 179445 [details] [review] Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. Created attachment 179446 [details] [review] Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass The tests are quite slow however. We can discuss the need of this test. *** This bug has been marked as a duplicate of bug 37245 *** Is there a new dependency here? I tried running the test and I'm getting an error: xt/pl_valid.t .. Can't locate Test/NoWarnings.pm in @INC (you may need to install the Test::NoWarnings module) I also get: Parse errors: No plan found in TAP output though I'm not sure if that's a separate error, or if it's just because the program fails before it reaches the plan tests line. (In reply to Emily Lamancusa (emlam) from comment #5) > Is there a new dependency here? I tried running the test and I'm getting an > error: > > xt/pl_valid.t .. Can't locate Test/NoWarnings.pm in @INC (you may need to > install the Test::NoWarnings module) libtest-nowarnings-perl deps has been added by bug 38944. Please pull the latest ktd images or you can also manually install the debian package. Created attachment 179740 [details] [review] Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 179741 [details] [review] Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signing off because the test suite passes with the patches. I also fixed the file permissions on pl_valid.t inline, because xt/find-misplaced-executables.t was complaining. Testing notes (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Install the new dependency: sudo cpanm Test::NoWarnings 3. Apply the patches. 4. Run all the tests: . ktd --shell --root . cd /kohadevbox/koha . perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests Created attachment 180240 [details] [review] Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 180241 [details] [review] Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Great to have this.. Passing QA Pushed for 25.05! Well done everyone, thank you! |