| Summary: | Cannot use dataTables export function on checkout table in members/moremember.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to stable --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aude.charillon, chughesman, dcook, fridolin.somers, gmcharlt, januszop, karie.straube, kkrueger, kyle, Laura.escamilla, lisette, nick, rcoert |
| Version: | Main | Keywords: | rel_24_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40147 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00,24.11.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 39389: Don't stringify the system preference value
Bug 39389: Don't stringify the system preference value Bug 39389: Don't stringify the system preference value Bug 39389: Don't stringify the system preference value |
||
|
Description
Lucas Gass (lukeg)
2025-03-19 20:44:31 UTC
We are experiencing this bug too. Created attachment 180402 [details] [review] Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Created attachment 180570 [details] [review] Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180626 [details] [review] Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Janne <janne.seppanen@lahti.fi> Trivial fix that makes perfect sense, QAing here. Created attachment 181878 [details] [review] Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Janne <janne.seppanen@lahti.fi> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Yep looks good at a glance. Generally I don't like to see quotes disappear from Javascript, but this is a sensible change which doesn't introduce any security issues. Pushed for 25.05! Well done everyone, thank you! Could this be considered for backport? I also have an error on this page, but it's: Uncaught TypeError: document.referrer.split(...)[1] is undefined Could bug 40147 be a similar issue? This is also an issue in 24.11 (tested on 24.11.07) and it would be good for the fix to be backported. *** Bug 40733 has been marked as a duplicate of this bug. *** Please port it to 24.11 -- see Bug 40733. Pushed to 24.11.x for 24.11.10 There may be other cases
I've run some grep :
git grep -E '= ?"\[% Koha.Preference' -- koha-tmpl/ | awk -F '(\(|\))' '{print $2}' | sort -u > sysprefs.txt
Then filter on boolean prefs :
> for i in $(cat sysprefs.txt) ; do grep $i installer/data/mysql/mandatory/sysprefs.sql | grep YesNo ; done
('ExtendedPatronAttributes','1',NULL,'Use extended patron IDs and attributes','YesNo'),
('OPACPlayMusicalInscripts','0','','If displayed musical inscripts, play midi conversion on the OPAC record details page.','YesNo'),
('OPACPopupAuthorsSearch','0','','Display the list of authors when clicking on one author.','YesNo'),
('StaffHighlightedWords','1','','Highlight search terms on staff interface','YesNo'),
('UnseenRenewals','0','','Allow renewals to be recorded as "unseen" by the library, and count against the patrons unseen renewals limit.','YesNo'),
We may have a closer look
|