Summary: | Combine Notices & Messaging Tabs | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Patrons | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
notices tab data
screenshot Solution for "all notices" problem? Bug 3941 - Combine Notices & Messaging Tabs [Signed Off] Bug 3941 - Combine Notices & Messaging Tabs Bug 3941: Follow up |
Description
Chris Cormack
2010-05-21 01:21:16 UTC
I added a MANUAL_ODUE notice for module circulation, using the same text as for my normal ODUE notice. Circulation > Overdues gives me a perl error: Global symbol "@overduedata" requires explicit package name at /home/koha/kohaclone/circ/overdue.pl line 204. Execution of /home/koha/kohaclone/circ/overdue.pl aborted due to compilation errors. hmmm, I think you might have reported that error the wrong bug Katrin, I havent pushed anything to do with 3941 You are right - I confused my open tabs in Firefox. The error message belongs to bug 4990. Changing the bug title because I think we're talking about combining these tabs in some way to make it clearer. Anyone have any other ideas? The only difference between them seems to be that members/notices.pl shows the content and members/messaging.pl does not. Am I missing anything? Should members/messaging.pl be dropped, and the output of members/notices.pl be made more readable? I think combining both into one tab is a good idea. A way to show the notice formatted would be nice - at the moment it's hard to figure out which items where listed in overdues etc Yes, I'm for combining tabs into one and showing the message in a more friendly fashion. I should also note that it seems that messages sent to the librarians are showing in these logs - like if the librarian gets a message when a hold is placed that message goes into the patron's log ... that might be fine, but I wanted to mention it in case others think it doesn't belong there. If this gets implemented it will make Bug 6593 obsolete. Created attachment 5551 [details] [review] Bug 3941 - Combine Notices & Messaging Tabs Changes to notices tab to make it a full replacement for messages tab. Removes messages tab from patron account. - repairs view of patron address in left column (category description, branch) - shows some explanation, when there are no messages for a borrower - makes the notice an expandable field, a click on the subject will expand the field to show the message content - makes message status and message transport type translatable, by moving the possible values into the template - removes the messaging tab from various menus - removes the files that were associated with the messaging tab - preserves the line breaks in message content to improve readability Also fixes Bug 6593 - Some information missing from the "Notices" tab. Thx to Owen Leonard and Chris Cormack for hints and help with making it work! :) Created attachment 5552 [details] [review] [Signed Off] Bug 3941 - Combine Notices & Messaging Tabs Changes to notices tab to make it a full replacement for messages tab. Removes messages tab from patron account. - repairs view of patron address in left column (category description, branch) - shows some explanation, when there are no messages for a borrower - makes the notice an expandable field, a click on the subject will expand the field to show the message content - makes message status and message transport type translatable, by moving the possible values into the template - removes the messaging tab from various menus - removes the files that were associated with the messaging tab - preserves the line breaks in message content to improve readability Also fixes Bug 6593 - Some information missing from the "Notices" tab. Signed-off-by: Liz Rea <lrea@nekls.org> Primarily a template change, with the removal of a now unnecessary script, and a minor modification to the params passed to the other script. One EXTREMELY tiny thing: once you click a notice title to expand it, clicking it a second time does not collapse it; you have to click a second notice title (if one exists) to collapse it and expand the other. So one notice will remain expanded forever after expanding the first (until you navigate away). This is not sufficient to block QA, however; it could be a follow up, or a separate enhancement. Marking as Passed QA Created attachment 5554 [details] [review] Bug 3941: Follow up Improving the notices field to make it possible - to expand more than one field at a time - hide the notice content with another click Follow up patch has my signoff and passed QA mark. Thanks, Katrin! Pushed, please test |