Bug 39421

Summary: Renewal date input field (and date picker) not showing on Circulation > Renew
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, david, gmcharlt, i.tortorella, kyle, lucas, m.de.rooy, phil, r.delahunty
Version: MainKeywords: rel_24_11_candidate
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/1082 Text to go in the release notes:
This restores the renewal due date input field and date picker on the Circulation > Renew page - this was missing. It changes the behavor slightly so that it matches the Circulation > Check in page (and other areas of Koha) - the barcode input field now has a settings icon, clicking this now shows the renewal date input field (with the date picker).
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks:    
Attachments: Bug 39421: Restore settings icon and date picker
Bug 39421: Restore missing date picker on Circulation > Renew
Bug 39421: (follow-up) Correct title attribute
Bug 39421: Restore missing date picker on Circulation > Renew
Bug 39421: (follow-up) Correct title attribute
[24.11] Bug 39421: Restore missing date picker on Circulation > Renew

Description Nick Clemens (kidclamp) 2025-03-22 15:33:34 UTC
To recreate:
Browse to Circulation->Checkins
Note the settings icon in the barcode box
Click it to see a date picker for checkin date
Browse to Circulation->Renewals
Note there is no icon
Inspect the page and see there is a picker, but it is hidden
Comment 1 Nick Clemens (kidclamp) 2025-03-22 15:34:24 UTC
Created attachment 179631 [details] [review]
Bug 39421: Restore settings icon and date picker
Comment 2 Nick Clemens (kidclamp) 2025-03-22 15:35:12 UTC
I attached patch that simply adds the button and JS needed -I am not sure that this is correct, would appreciate a second set of eyes
Comment 3 Phil Ringnalda 2025-03-28 17:24:37 UTC
I don't have an opinion about whether it's better to give it the toggle, or to put it back to always showing like it used to, but I did spend too much time figuring out how it broke. The "show" in class="circ-settings show" is a class we had in our BS4 bootstrap.min.css that sets display: block !important, and we no longer have it.
Comment 4 David Nind 2025-03-29 00:30:05 UTC
Created attachment 179897 [details] [review]
Bug 39421: Restore missing date picker on Circulation > Renew

This patch restores the renewal date input field (with a date
picker) for Circulation > Renew. This was missing.

It changes the behavor slightly so that it mirrors Circulation >
Check in. A settings icon is included in the barcode field,
clicking this then shows the date field with the date picker
(and any other options).

Previously on the renewals page (24.05.x and earlier), there was
no settings icon in the barcode field and the date input field
with date picker was already shown.

This user interface pattern is used elsewhere in Koha, and this
chnage will help improve consistency.

Test plan:
1. Browse to Circulation > Check in.
2. Note the settings icon in the barcode form field.
3. Click it to show the the return date field with a date picker,
   and other options.
4. Browse to Circulation > Renew.
5. Note there is no settings icon.
6. Apply the patch.
7. Repeat step 4 - note that there is now a settings icon.
8. Click the settings icon to show the renewal date form field.
9. Click the input field to show teh date picker.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-03-29 00:45:16 UTC
I've signed off (I amended the commit message to add the test plan, and added a description).

I checked 24.11, 24.05, and 23.11 (from demo installations).

The renewal date input field was missing from 24.11, but for 24.05 and 23.11 there was no settings icon in the barcode input field - the renewal date field was already shown when you loaded the page.

However, I think there is some merit in mirroring the behavour used for Circulation > Check in, and elsewhere in Koha. It is a common user interface pattern used in Koha and helps improve consistency.

If there are no other options shown on this page, then some staff may find it an extra click.

Maybe we should add (on another bug?) a "Remember renewal date for next renewal" checkbox.
Comment 6 Marcel de Rooy 2025-04-18 08:14:21 UTC
Could you please find a better wording for the title? This is not checkin :)
Comment 7 Owen Leonard 2025-04-18 13:41:20 UTC
Created attachment 181159 [details] [review]
Bug 39421: (follow-up) Correct title attribute
Comment 8 Marcel de Rooy 2025-04-22 12:16:00 UTC
Created attachment 181250 [details] [review]
Bug 39421: Restore missing date picker on Circulation > Renew

This patch restores the renewal date input field (with a date
picker) for Circulation > Renew. This was missing.

It changes the behavor slightly so that it mirrors Circulation >
Check in. A settings icon is included in the barcode field,
clicking this then shows the date field with the date picker
(and any other options).

Previously on the renewals page (24.05.x and earlier), there was
no settings icon in the barcode field and the date input field
with date picker was already shown.

This user interface pattern is used elsewhere in Koha, and this
chnage will help improve consistency.

Test plan:
1. Browse to Circulation > Check in.
2. Note the settings icon in the barcode form field.
3. Click it to show the the return date field with a date picker,
   and other options.
4. Browse to Circulation > Renew.
5. Note there is no settings icon.
6. Apply the patch.
7. Repeat step 4 - note that there is now a settings icon.
8. Click the settings icon to show the renewal date form field.
9. Click the input field to show teh date picker.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2025-04-22 12:16:03 UTC
Created attachment 181251 [details] [review]
Bug 39421: (follow-up) Correct title attribute

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Katrin Fischer 2025-04-23 07:43:14 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 11 Pedro Amorim 2025-07-23 13:15:46 UTC
Created attachment 184551 [details] [review]
[24.11] Bug 39421: Restore missing date picker on Circulation > Renew

This patch restores the renewal date input field (with a date
picker) for Circulation > Renew. This was missing.

It changes the behavor slightly so that it mirrors Circulation >
Check in. A settings icon is included in the barcode field,
clicking this then shows the date field with the date picker
(and any other options).

Previously on the renewals page (24.05.x and earlier), there was
no settings icon in the barcode field and the date input field
with date picker was already shown.

This user interface pattern is used elsewhere in Koha, and this
chnage will help improve consistency.

Test plan:
1. Browse to Circulation > Check in.
2. Note the settings icon in the barcode form field.
3. Click it to show the the return date field with a date picker,
   and other options.
4. Browse to Circulation > Renew.
5. Note there is no settings icon.
6. Apply the patch.
7. Repeat step 4 - note that there is now a settings icon.
8. Click the settings icon to show the renewal date form field.
9. Click the input field to show teh date picker.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

PA amended: Squashed both patches for 24.11