Summary: | The pages are missing semantic tags that identify the regions of the pages. | ||
---|---|---|---|
Product: | Koha | Reporter: | Nina Martinez <nina.martinez> |
Component: | Accessibility | Assignee: | Nina Martinez <nina.martinez> |
Status: | Pushed to stable --- | QA Contact: | Owen Leonard <oleonard> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, claire.hernandez, dcook, e.betemps, jonathan.druart, julian.maurice, lucas, martin.renvoize, matt.blenkinsop, oleonard |
Version: | unspecified | Keywords: | release-notes-needed |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.01
|
Circulation function: | |
Attachments: |
Bug 39434: Change the div tags that represent the header and main regions to semantic tags.
Bug 39434: Change the div tags that represent the header and main regions to semantic tags. Bug 39434: Change the div tags that represent the header and main regions to semantic tags. Bug 39434: (follow-up) Fix a few more instance Bug 39434: Tidy |
Description
Nina Martinez
2025-03-24 09:52:21 UTC
Created attachment 179817 [details] [review] Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Hi, as I fear forgetting one or more pages of the OPAC, is there any way to list : - the pages we have to test ? - the syspref and other settings to get on the staff interface ? I agree this is hard to test without a proper test plan. I tried making one but haven't managed to finish all of it (even after several hours). Here's what I have so far (I left out the numbers for each step bc it is easier to reorder if there are no numbers) To test: . Apply patch and restart_all . Enable the following system preferences - OpacBrowser - useDischarge - OPACHoldsHistory - ILLModule - OPACPrivacy - UseRecalls - ArticleRequests - OPACReportProblem - OPACVirtualCard * For each page, make sure the page looks OK and there is a main tag in the page inspector (unless noted otherwise) . Go to the OPAC (opac-main/masthead.inc - header tag in addition to main tag) . Click on 'Advanced search' (opac-advsearch) . Make a search that will return several results (e.g. shakespeare) (opac-results) . Click on a title to access the detailed record (opac-detail) . Click MARC view (opac-MARCdetail) . Click ISBD view (opac-ISBDdetail) . Click 'Place hold' (opac-reserve) . Go back to the record . Click 'Place recall' (opac-recall) . Go back to the record . Click 'Request article' (opac-request-article) . Click 'Add to your lists' (opac-addbybiblionumber) . Enter a list name . Click 'Save' . Click 'Add to your cart' . Click 'Cart' at the top of the page (opac-basket) . Click 'Send' (opac-sendbasketform) . Close the window . Close the cart window . Click the 'Comments' tab . Click 'Post your comments on this title' (opac-review) . Click on 'Course reserves' (opac-course-reserves) . Click on 'first course' (opac-course-details) . Click on 'Browse by hierarchy' (opac-browser) . Log in (if you're not already logged in, if you already are, go to Your account) (opac-user) . Click on the 'Charges' tab (opac-account) . Click on the 'Personal details' tab (opac-memberentry) . Change some information in the form . Click 'Submit update request' (opac-memberentry-update-submitted???) . Click on the 'Tags' tab (opac-tags) . Click on the 'Change password' tab (opac-passwd) . Click on the 'Search history' tab (opac-search-history) . Click on the 'Checkout history' tab (opac-readingrecord) . Click on the 'Privacy' tab (opac-privacy) . Click on the 'Holds history' tab (opac-holdshistory) . Click on the 'Recalls history' tab (opac-recalls) . Click on the 'Purchase suggestions' tab (opac-suggestions) . Click on the 'Messaging' tab (opac-messaging) . Click on the 'Lists' tab (opac-shelves) . Click on the list name . Click 'Send list' (opac-sendshelfform) . Close the window . Click on the 'Ask for discharge' tab (opac-discharge) . Click on the 'Interlibrary loan requests' tab (opac-illrequests) . Click on the 'My virtual card' tab (opac-virtual-card) . Click on 'Authority search' (opac-authorities-home) . Click on 'Submit' (opac-authoritiessearchresultlist???) . Click on 'Details' next to a result (opac-auth-detail) . Click on 'MARC view' (opac-auth-MARCdetail) . Click on 'Libraries' (opac-library) . Click on 'Report a problem' (opac-reportproblem) . Go to cgi-bin/koha/ilsdi.pl (ilsdi) . Enable OpacMaintenance . In the staff interface, go to Administration > System preferences . Search for OpacMaintenance . Set to 'Show' . Click 'Save all OPAC preferences' . Go to the OPAC (it should redirect to the maintenance page) (maintenance) This test plan is still missing all of these pages opac-account-pay-error opac-alert-subscribe opac-alert-subscriptions opac-auth opac-blocked opac-browse opac-curbside-pickups opac-downloadcart opac-downloadshelf opac-full-serial-issues opac-idref opac-imageviewer opac-issue-note opac-overdrive-search opac-page opac-password-recovery opac-patron-consent opac-registration-confirmation opac-registration-email-sent opac-registration-invalid opac-reset-password opac-restrictedpage opac-routing-lists opac-serial-issues opac-shareshelf opac-showreviews opac-tags_subject opac-topissues Fell free to rework the test plan. I don't think I will have time to finish it. As an aside, I feel like this could be easier to test if it was divided in several different bugs, but maybe I'm just too lazy... Created attachment 180132 [details] [review] Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> Created attachment 183004 [details] [review] Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 183005 [details] [review] Bug 39434: (follow-up) Fix a few more instance Signed-off-by: Owen Leonard <oleonard@myacpl.org> Nice work everyone! Pushed to main for 25.11 Author, QA and RM: please use the git hook AND the QA script! Created attachment 183363 [details] [review] Bug 39434: Tidy (In reply to Jonathan Druart from comment #9) > Created attachment 183363 [details] [review] [review] > Bug 39434: Tidy Patch pushed. Nice work everyone! Pushed to 25.05.x for 25.05.03 |