Bug 39441

Summary: Some templates have div.container instead of div.container-fluid
Product: Koha Reporter: David Cook <dcook>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Lisette Scheer <lisette>
Severity: minor    
Priority: P5 - low CC: david, lisette
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This updates a few templates so that div.container is replaced with div.container-fluid. div.container has a fixed maximum width that isn't consistent with the rest of Koha. An example where this caused display issues - the staff interface cart: the action icons were bunched up to the left, instead of being spread evenly across the pop-up window width.
Version(s) released in:
25.11.00
Circulation function:
Attachments: Bug 39441: Some templates have div.container instead of div.container-fluid
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid

Description David Cook 2025-03-25 01:14:52 UTC
The staff interface cart "looks funny" at the moment. It's all bunched up on the left side.

I'd say the reason is that the max-width for .container from staff-global.css is being applied which restricts it to 540px.

I reckon we should add a class or ID to override the max-width for the cart to always be 100%.

--

Curious what you think of this one, Owen.
Comment 1 Owen Leonard 2025-05-23 16:51:48 UTC
The Bootstrap class ".container" gives you a <div> with a maximum width. We always want the main part of the page to be full width, using offset classes when necessary.
Comment 2 Owen Leonard 2025-05-23 17:10:56 UTC
Created attachment 182776 [details] [review]
Bug 39441: Some templates have div.container instead of div.container-fluid

This patch updates a few templates so that div.container is replaced
with div.container-fluid. div.container gives us a fixed maximum width
that isn't consistent the rest of Koha.

To test, apply the patch and go to the staff interface.

- Perform a catalog search which will return multiple results.
- In the search results, check multiple results and click "Add to cart."
- Click the cart icon in the top menu to trigger the cart popup.
- The contents of the cart popup should fill the whole width of the
  window.
- The other instances of this are less noticeable because of how the
  pages work. These changes are more about consistency:
  - The OPAC place hold page
  - The club enrollment process (both in the OPAC and the staff
    interface)
  - As long as these interactions work correctly all is good.

Sponsored-by: Athens County Public Libraries
Comment 3 David Nind 2025-06-04 10:36:30 UTC
Created attachment 182936 [details] [review]
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid

This patch updates a few templates so that div.container is replaced
with div.container-fluid. div.container gives us a fixed maximum width
that isn't consistent the rest of Koha.

To test, apply the patch and go to the staff interface.

- Perform a catalog search which will return multiple results.
- In the search results, check multiple results and click "Add to cart."
- Click the cart icon in the top menu to trigger the cart popup.
- The contents of the cart popup should fill the whole width of the
  window.
- The other instances of this are less noticeable because of how the
  pages work. These changes are more about consistency:
  - The OPAC place hold page
  - The club enrollment process (both in the OPAC and the staff
    interface)
  - As long as these interactions work correctly all is good.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lisette Scheer 2025-06-30 21:15:15 UTC
Created attachment 183656 [details] [review]
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid

This patch updates a few templates so that div.container is replaced
with div.container-fluid. div.container gives us a fixed maximum width
that isn't consistent the rest of Koha.

To test, apply the patch and go to the staff interface.

- Perform a catalog search which will return multiple results.
- In the search results, check multiple results and click "Add to cart."
- Click the cart icon in the top menu to trigger the cart popup.
- The contents of the cart popup should fill the whole width of the
  window.
- The other instances of this are less noticeable because of how the
  pages work. These changes are more about consistency:
  - The OPAC place hold page
  - The club enrollment process (both in the OPAC and the staff
    interface)
  - As long as these interactions work correctly all is good.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Lisette Scheer 2025-06-30 21:16:49 UTC
Created attachment 183657 [details] [review]
Bug 39441: Some staff interface templates have div.container instead of div.container-fluid

This patch updates a few templates so that div.container is replaced
with div.container-fluid. div.container gives us a fixed maximum width
that isn't consistent the rest of Koha.

To test, apply the patch and go to the staff interface.

- Perform a catalog search which will return multiple results.
- In the search results, check multiple results and click "Add to cart."
- Click the cart icon in the top menu to trigger the cart popup.
- The contents of the cart popup should fill the whole width of the
  window.
- The other instances of this are less noticeable because of how the
  pages work. These changes are more about consistency:
  - The OPAC place hold page
  - The club enrollment process (both in the OPAC and the staff
    interface)
  - As long as these interactions work correctly all is good.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 6 Lucas Gass (lukeg) 2025-06-30 22:03:28 UTC
Nice work everyone!

Pushed to main for 25.11