Bug 39448

Summary: Layout improvement for search filter administration
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Passed QA --- QA Contact: Lisette Scheer <lisette>
Severity: enhancement    
Priority: P5 - low CC: felicie.thiery, lisette
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 39448: Layout improvement for search filter administration
Bug 39448: Layout improvement for search filter administration
Bug 39448: Layout improvement for search filter administration

Description Owen Leonard 2025-03-25 15:03:43 UTC
I have a few minor markup changes I'd like to make to admin/search_filters.tt, especially to the layout of the "Edit filter" modal.
Comment 1 Owen Leonard 2025-03-26 12:31:45 UTC
Created attachment 179726 [details] [review]
Bug 39448: Layout improvement for search filter administration

This patch makes a few minor changes to the search filter administration
template.

To test, apply the patch and rebuild the staff interface CSS.

- If the SavedSearchFilters system preference is not enabled, go to
  Administration -> System preferences and enable it.
- Perform a catalog search.
  - From the search results page, click "Save as search filter" at the
    top of the results.
  - Save your filter.
- Go to Administration -> Search filters.
  - The table of filters should be wrapped in a "page-section" div with
    the heading above it.
  - In the "Actions" column the buttons should be aligned in a row with
    space between each.
  - Click "Edit filter"
    - In the modal the form fields should be well laid out.

Sponsored-by: Athens County Public Libraries
Comment 2 Felicie 2025-04-02 12:50:55 UTC
Created attachment 180327 [details] [review]
Bug 39448: Layout improvement for search filter administration

This patch makes a few minor changes to the search filter administration
template.

To test, apply the patch and rebuild the staff interface CSS.

- If the SavedSearchFilters system preference is not enabled, go to
  Administration -> System preferences and enable it.
- Perform a catalog search.
  - From the search results page, click "Save as search filter" at the
    top of the results.
  - Save your filter.
- Go to Administration -> Search filters.
  - The table of filters should be wrapped in a "page-section" div with
    the heading above it.
  - In the "Actions" column the buttons should be aligned in a row with
    space between each.
  - Click "Edit filter"
    - In the modal the form fields should be well laid out.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Felicie <felicie.thiery@biblibre.com>
Comment 3 Lisette Scheer 2025-07-02 16:58:50 UTC
Created attachment 183707 [details] [review]
Bug 39448: Layout improvement for search filter administration

This patch makes a few minor changes to the search filter administration
template.

To test, apply the patch and rebuild the staff interface CSS.

- If the SavedSearchFilters system preference is not enabled, go to
  Administration -> System preferences and enable it.
- Perform a catalog search.
  - From the search results page, click "Save as search filter" at the
    top of the results.
  - Save your filter.
- Go to Administration -> Search filters.
  - The table of filters should be wrapped in a "page-section" div with
    the heading above it.
  - In the "Actions" column the buttons should be aligned in a row with
    space between each.
  - Click "Edit filter"
    - In the modal the form fields should be well laid out.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Felicie <felicie.thiery@biblibre.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>