|
Description
Lucas Gass (lukeg)
2025-03-30 07:10:44 UTC
Created attachment 179902 [details] [review] Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Created attachment 179903 [details] [review] Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Created attachment 179942 [details] [review] Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Signed-off-by: Andrew <andrew.auld@openfifth.co.uk> Sounds so beautiful! Lovely work Lucas. :) Created attachment 181182 [details] [review] Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Signed-off-by: Andrew <andrew.auld@openfifth.co.uk> rebased for current main, setting back to 'Signed off' Created attachment 181189 [details] [review] Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Signed-off-by: Andrew <andrew.auld@openfifth.co.uk> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> This works, and makes sense. It's done the same way in the playSound function on staff-global.js Nice work. Passing QA Pushed for 25.05! Well done everyone, thank you! Any chance for a 24.11 backport on this one? Pushed to 24.11.x for 24.11.10 |