Bug 39536

Summary: "Add patron to list" silently fails if patron does not have cardnumber
Product: Koha Reporter: David Cook <dcook>
Component: PatronsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39535
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description David Cook 2025-04-03 06:01:21 UTC
From the moremember.pl page, if you try to add a patron to a list via "Add patron to list", it will silently fail if the patron does not have a cardnumber.

This is particularly wild, because the patron_list_id and borrowernumber are sent in the request. But "patrons_to_add" is empty because there's no cardnumber.

Koha::List::Patron::AddPatronsToList actually supports both borrowernumber and cardnumber, so it should actually be a fairly easy fix in theory.

But we'd have to be careful about making the change to be clear across the board...