Bug 39555

Summary: Clarify "On loan" column on "transfers to send" page
Product: Koha Reporter: Heather Rommens <heather>
Component: CirculationAssignee: Andrew Fuerste-Henry <andrew>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: andrew, david, gmcharlt, kyle.m.hall, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the transfer to send table (Circulation > Transfers > Transfers to send) to clarify the values shown - if an item is not checked out, it is now shown as "Not checkout out" instead of "On shelf" - which was confusing, as it could be in transit. Changes made: 1. The column "On loan" is now labelled "Date due". 2. If an item is not checked out, the value now shown is "Not checked out", instead of "On shelf". (Previously, if an item was in transit to another location (for example), it was shown as "On shelf", which was confusing.) 3. If an item is checked out, the value shown is "Due [DATE]" (no change in behavour).
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39555: Relabel "On Loan" in Transfers to Send
Bug 39555: Relabel "On Loan" in Transfers to Send
Bug 39555: Relabel "On Loan" in Transfers to Send

Description Heather Rommens 2025-04-03 20:27:57 UTC
The Transfers to send table contains an "On Loan" column that communicates whether an item is checked out (On Loan) or not. However, if an item is not currently checked out, the value "On shelf" displays, which can be misleading. For example, if an item is in transit to another location, this field still reads as "On shelf". This is confusing, since the item is not actually on the shelf anymore, but rather in transit. One solution might be to have the values "Checked out" or "Not checked out" display in this column instead.
Comment 1 Andrew Fuerste-Henry 2025-04-04 19:28:27 UTC
Created attachment 180675 [details] [review]
Bug 39555: Relabel "On Loan" in Transfers to Send

This test plan edits database values rather than getting these transfers requested via StockRotation. I don't believe that impacts the validity of the testing.

To test:
1 - enable StockRotation syspref (otherwise the Transfers to Show page doesn't show up)
2 - go to /cgi-bin/koha/circ/branchtransfers.pl and transfer an item
3 - log into the database and "update branchtransfers set datesent=NULL where branchtransfer_id=[your transfer]"
4 - go to /cgi-bin/koha/circ/transfers_to_send.pl
5 - confirm there is a column named "On shelf" and your transfer shows the value "On shelf" in that column
6 - back in the database, "update items set onloan=curdate() where itemnumber=[your item]"
7 - reload Transers to Send, confirm it now shows "Due [today]" for your item in the On Loan column
8 - apply patch
9 - reload Transfers to Send, confirm column is now titled "Date due" and the value for your item is still the due date
10 - back in the database, "update items set onloan=NULL where itemnumber=[your item]"
11 - reload Transfers to Send, confirm your item now shows a value of "Not checked out"
Comment 2 David Nind 2025-04-12 03:40:38 UTC
Created attachment 180889 [details] [review]
Bug 39555: Relabel "On Loan" in Transfers to Send

This test plan edits database values rather than getting these transfers requested via StockRotation. I don't believe that impacts the validity of the testing.

To test:
1 - enable StockRotation syspref (otherwise the Transfers to Show page doesn't show up)
2 - go to /cgi-bin/koha/circ/branchtransfers.pl and transfer an item
3 - log into the database and "update branchtransfers set datesent=NULL where branchtransfer_id=[your transfer]"
4 - go to /cgi-bin/koha/circ/transfers_to_send.pl
5 - confirm there is a column named "On shelf" and your transfer shows the value "On shelf" in that column
6 - back in the database, "update items set onloan=curdate() where itemnumber=[your item]"
7 - reload Transers to Send, confirm it now shows "Due [today]" for your item in the On Loan column
8 - apply patch
9 - reload Transfers to Send, confirm column is now titled "Date due" and the value for your item is still the due date
10 - back in the database, "update items set onloan=NULL where itemnumber=[your item]"
11 - reload Transfers to Send, confirm your item now shows a value of "Not checked out"

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2025-05-09 14:30:16 UTC
Created attachment 182185 [details] [review]
Bug 39555: Relabel "On Loan" in Transfers to Send

This test plan edits database values rather than getting these transfers requested via StockRotation. I don't believe that impacts the validity of the testing.

To test:
1 - enable StockRotation syspref (otherwise the Transfers to Show page doesn't show up)
2 - go to /cgi-bin/koha/circ/branchtransfers.pl and transfer an item
3 - log into the database and "update branchtransfers set datesent=NULL where branchtransfer_id=[your transfer]"
4 - go to /cgi-bin/koha/circ/transfers_to_send.pl
5 - confirm there is a column named "On shelf" and your transfer shows the value "On shelf" in that column
6 - back in the database, "update items set onloan=curdate() where itemnumber=[your item]"
7 - reload Transers to Send, confirm it now shows "Due [today]" for your item in the On Loan column
8 - apply patch
9 - reload Transfers to Send, confirm column is now titled "Date due" and the value for your item is still the due date
10 - back in the database, "update items set onloan=NULL where itemnumber=[your item]"
11 - reload Transfers to Send, confirm your item now shows a value of "Not checked out"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Katrin Fischer 2025-05-12 16:32:14 UTC
Pushed for 25.05!

Well done everyone, thank you!