Bug 39565

Summary: OPACVirtualCard system preferences should not be in Suggestions section
Product: Koha Reporter: Aude Charillon <aude.charillon>
Component: System AdministrationAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Pushed to main --- QA Contact: David Nind <david>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, david, dcook, gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This enhancement moves the OPACVirtualCard system preferences (OPACVirtualCard and OPACVirtualCardBarcode) from the OPAC suggestion section to the OPAC features section.
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 26777    
Bug Blocks:    
Attachments: Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section
Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section
Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section
Bug 39565: Move OPACVirtualCard system preferences to features section

Description Aude Charillon 2025-04-04 13:38:13 UTC
OPACVirtualCard and OPACVirtualCardBarcode are currently in the OPAC > Suggestions section. This doesn't make sense, as this section groups together preferences related to purchase suggestions.

OPACVirtualCard and OPACVirtualCardBarcode should be moved to a more relevant section with the OPAC preferences, likely Features.
Comment 1 Caroline Cyr La Rose 2025-04-08 13:57:26 UTC
Created attachment 180722 [details] [review]
Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section

This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system
preferences from the Suggestions subsection of the OPAC preferences to the
Features subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > OPAC
3. Search the page (Ctrl + F) for OPACVirtualCard
   --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode)
       should be in the Features section
Comment 2 PTFS Europe Sandboxes 2025-04-08 16:51:57 UTC
Created attachment 180729 [details] [review]
Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section

This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system
preferences from the Suggestions subsection of the OPAC preferences to the
Features subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > OPAC
3. Search the page (Ctrl + F) for OPACVirtualCard
   --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode)
       should be in the Features section

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 3 Aude Charillon 2025-04-08 16:53:48 UTC
Works as described - signing off.
Comment 4 David Nind 2025-04-24 22:08:25 UTC
I thought I would have a go at QAing this one as I understand the code for this one!

The patch no longer applies 8-(...

Once the patch applies again, could you amend the commit message to follow the guidelines? https://wiki.koha-community.org/wiki/Commit_messages
- Subject line: Bug 39565: ....
- Maybe the title for the commit message should be "Move OPACVirtualCard system preferences to the correct section"

David

git bz apply 39565

Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section

180729 - Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
error: Failed to merge in the changes.
Patch failed at 0001 Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section
Comment 5 Caroline Cyr La Rose 2025-04-25 18:07:02 UTC
Created attachment 181550 [details] [review]
Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section

This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system
preferences from the Suggestions subsection of the OPAC preferences to the
Features subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > OPAC
3. Search the page (Ctrl + F) for OPACVirtualCard
   --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode)
       should be in the Features section

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 6 Caroline Cyr La Rose 2025-04-25 18:07:29 UTC
Thanks for checking David! I rebased and put it back in Signed Off.
Comment 7 David Nind 2025-04-25 18:48:05 UTC
Created attachment 181553 [details] [review]
Bug 39565: Move OPACVirtualCard system preferences to features section

This patch moves the OPACVirtualCard and OPACVirtualCardBarcode system
preferences from the Suggestions subsection of the OPAC preferences to the
Features subsection.

To test:
1. Apply patch
2. Go to Administration > System preferences > OPAC
3. Search the page (Ctrl + F) for OPACVirtualCard
   --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode)
       should be in the Features section

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2025-04-25 18:50:25 UTC
Thanks Caroline!

Passed QA:
- Edited the commit message to change the title to Bug XXXX: ... (from Bug XXXX - ...)
- QA script happy
- Works as expected.
Comment 9 Katrin Fischer 2025-04-28 16:54:55 UTC
Pushed for 25.05!

Well done everyone, thank you!