Bug 39604

Summary: Remember for the session for this patron doesn't remember to cancel a hold
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: dcook, gmcharlt, karie.straube, kebliss, kyle.m.hall, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 39604: Remember cancelreserve choice when remembering patron for session
Bug 39604: Remember cancelreserve choice when remembering patron for session
Bug 39604: Remember cancelreserve choice when remembering patron for session

Description Lucas Gass (lukeg) 2025-04-10 17:30:18 UTC
TO recreate:

1. Put a few items on hold and make note of the barcodes. 
2. Check out one of the items to a patron who doesn't have the hold
3. Check the cancel hold radio button 
4. Also check the Remember for the session for this patron 
5. Click 'Yes, check out'
6. Notice the item is checked out and the hold is cancelled 
7. No checkout another on hold item to the same patron 
8. No confirm screen ( good )
9. The item is checked out ( good )
10. The hold is not cancelled. ( bad )
Comment 1 Lucas Gass (lukeg) 2025-04-12 16:36:50 UTC
This also is true of 'Revert waiting hold', it should also be remembered for the session if it is choosen.
Comment 2 Lucas Gass (lukeg) 2025-04-14 17:47:16 UTC
Created attachment 180924 [details] [review]
Bug 39604: Remember cancelreserve choice when remembering patron for session

To test:
1. Put a few items on hold and make note of the barcodes.
2. Check out one of the items to a patron who doesn't have the hold
3. Check the cancel hold radio button
4. Also check the Remember for the session for this patron
5. Click 'Yes, check out'
6. Notice the item is checked out and the hold is cancelled
7. No checkout another on hold item to the same patron
8. No confirm screen ( good )
9. The item is checked out ( good )
10. The hold is not cancelled. ( bad )
11. APPLY PATCH and restart all
12. Try steps 1 - 9 again. This time the 2nd hold should be cancelled.
Comment 3 Roman Dolny 2025-04-14 18:50:55 UTC
Created attachment 180927 [details] [review]
Bug 39604: Remember cancelreserve choice when remembering patron for session

To test:
1. Put a few items on hold and make note of the barcodes.
2. Check out one of the items to a patron who doesn't have the hold
3. Check the cancel hold radio button
4. Also check the Remember for the session for this patron
5. Click 'Yes, check out'
6. Notice the item is checked out and the hold is cancelled
7. No checkout another on hold item to the same patron
8. No confirm screen ( good )
9. The item is checked out ( good )
10. The hold is not cancelled. ( bad )
11. APPLY PATCH and restart all
12. Try steps 1 - 9 again. This time the 2nd hold should be cancelled.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Martin Renvoize (ashimema) 2025-05-09 14:28:41 UTC
Created attachment 182184 [details] [review]
Bug 39604: Remember cancelreserve choice when remembering patron for session

To test:
1. Put a few items on hold and make note of the barcodes.
2. Check out one of the items to a patron who doesn't have the hold
3. Check the cancel hold radio button
4. Also check the Remember for the session for this patron
5. Click 'Yes, check out'
6. Notice the item is checked out and the hold is cancelled
7. No checkout another on hold item to the same patron
8. No confirm screen ( good )
9. The item is checked out ( good )
10. The hold is not cancelled. ( bad )
11. APPLY PATCH and restart all
12. Try steps 1 - 9 again. This time the 2nd hold should be cancelled.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 5 Katrin Fischer 2025-05-13 16:47:55 UTC
Pushed for 25.05!

Well done everyone, thank you!