Description
Pedro Amorim
2025-04-16 11:03:03 UTC
Created attachment 181001 [details] [review] Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t Created attachment 181002 [details] [review] Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. The approach seems sound to me and works; I've already spoken to Pedro about the `new_` name and we agreed to perhaps rename to `create_` to clarify that in this case the method is actually storing data now do no subsequent 'store' is required. Created attachment 181109 [details] [review] Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Created attachment 181110 [details] [review] Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Created attachment 181209 [details] [review] Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 181210 [details] [review] Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. Signed-off-by: David Nind <david@davidnind.com> Created attachment 181211 [details] [review] Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Apply the first patch. 2. The tests should fail: prove t/db_dependent/Koha/Pseudonymization.t 3. Apply the remaining patches. 3. The tests should now pass: prove t/db_dependent/Koha/Pseudonymization.t Created attachment 181382 [details] [review] Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 181383 [details] [review] Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 181384 [details] [review] Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 181385 [details] [review] Bug 39652 (QA follow-up): Update misc/maintenance/pseudonymize_statistics.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Fixed before pushing: Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - be2ae9c86ab Pushed for 25.05! Well done everyone, thank you! |