Description
kristinamason
2025-04-19 04:47:16 UTC
Good catch! Created attachment 181529 [details] [review] Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! Created attachment 181556 [details] [review] Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 181849 [details] [review] Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> I know this works, but using a non-breaking space ( ) feels like cheating here and might also effect narrower displays (haven't tested that part). I would have expected a normal space before the string - did this not work because of the tidy or some other reason? (Failed QA to be read as "I have a question!") Created attachment 182016 [details] [review] Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. Created attachment 182040 [details] [review] Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 182087 [details] [review] Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> This is certainly a better approach and I'm PQAing this alternate patch.. However.. I'd still like the question of when to use the different ways of adding a space answered.. I'm seeing a lot of these space bugs in my QA run today and they all solve it differently. https://chat.koha-community.org/koha-community/pl/wiopmtr7j3835df3yfi6q64ooy Pushed for 25.05! Well done everyone, thank you! |