Bug 39688

Summary: Space missing between "suspended" and "until" in the holds summary table
Product: Koha Reporter: kristinamason
Component: AccessibilityAssignee: Laura Escamilla <Laura.escamilla>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: Laura.escamilla, martin.renvoize, matt.blenkinsop, oleonard
Version: Main   
Hardware: All   
OS: All   
URL: http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: The holds table
Bug 39688: Added non-breaking space between Suspended and until
Bug 39688: Added non-breaking space between Suspended and until
Bug 39688: Added non-breaking space between Suspended and until
Bug 39688: (alternate) Improve i18n and spacing
Bug 39688: (alternate) Improve i18n and spacing
Bug 39688: (alternate) Improve i18n and spacing

Description kristinamason 2025-04-19 04:47:16 UTC
Created attachment 181196 [details]
The holds table

Issue: A space is missing between "suspended" and "until" in the holds table if a hold is suspended.

To reproduce: 
1. Log into Koha as an end user (not staff) http://localhost:8080/
2. Search for a book
3. Put a hold on that book
4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1
5. Click the Holds tab to view your holds.
6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold.
7. View the Status column on the Holds tab
8. Note it says Suspendeduntil and the date

Expectation: It should say "Suspended until", which has a space in the middle. 

Screenshot attached
Comment 1 Katrin Fischer 2025-04-22 15:04:59 UTC
Good catch!
Comment 2 Laura Escamilla 2025-04-25 14:24:38 UTC
Created attachment 181529 [details] [review]
Bug 39688: Added non-breaking space between Suspended and until

To test:
1. Log into Koha as an end user (not staff) http://localhost:8080/
2. Search for a book
3. Put a hold on that book
4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1
5. Click the Holds tab to view your holds.
6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold.
7. View the Status column on the Holds tab
8. Note it says Suspendeduntil and the date
9. Apply the patch.
10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’.
11. Sign off and have a wonderful day!
Comment 3 Roman Dolny 2025-04-25 20:15:50 UTC
Created attachment 181556 [details] [review]
Bug 39688: Added non-breaking space between Suspended and until

To test:
1. Log into Koha as an end user (not staff) http://localhost:8080/
2. Search for a book
3. Put a hold on that book
4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1
5. Click the Holds tab to view your holds.
6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold.
7. View the Status column on the Holds tab
8. Note it says Suspendeduntil and the date
9. Apply the patch.
10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’.
11. Sign off and have a wonderful day!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Martin Renvoize (ashimema) 2025-05-02 10:37:42 UTC
Created attachment 181849 [details] [review]
Bug 39688: Added non-breaking space between Suspended and until

To test:
1. Log into Koha as an end user (not staff) http://localhost:8080/
2. Search for a book
3. Put a hold on that book
4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1
5. Click the Holds tab to view your holds.
6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold.
7. View the Status column on the Holds tab
8. Note it says Suspendeduntil and the date
9. Apply the patch.
10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’.
11. Sign off and have a wonderful day!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 5 Katrin Fischer 2025-05-06 16:34:35 UTC
I know this works, but using a non-breaking space (&nbsp;) feels like cheating here and might also effect narrower displays (haven't tested that part).
I would have expected a normal space before the string - did this not work because of the tidy or some other reason?

(Failed QA to be read as "I have a question!")
Comment 6 Owen Leonard 2025-05-07 11:26:34 UTC
Created attachment 182016 [details] [review]
Bug 39688: (alternate) Improve i18n and spacing

Reworking the template logic of this section improves the spacing and
makes it so that the strings make more sense in translation.
Comment 7 Roman Dolny 2025-05-07 19:06:12 UTC
Created attachment 182040 [details] [review]
Bug 39688: (alternate) Improve i18n and spacing

Reworking the template logic of this section improves the spacing and
makes it so that the strings make more sense in translation.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 8 Martin Renvoize (ashimema) 2025-05-08 14:56:17 UTC
Created attachment 182087 [details] [review]
Bug 39688: (alternate) Improve i18n and spacing

Reworking the template logic of this section improves the spacing and
makes it so that the strings make more sense in translation.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 9 Martin Renvoize (ashimema) 2025-05-08 14:57:57 UTC
This is certainly a better approach and I'm PQAing this alternate patch..

However.. I'd still like the question of when to use the different ways of adding a space answered.. I'm seeing a lot of these space bugs in my QA run today and they all solve it differently.

https://chat.koha-community.org/koha-community/pl/wiopmtr7j3835df3yfi6q64ooy
Comment 10 Katrin Fischer 2025-05-09 07:14:22 UTC
Pushed for 25.05!

Well done everyone, thank you!