Summary: | Fix test case t/db_dependent/Authority/Merge.t broken in 34739 | ||
---|---|---|---|
Product: | Koha | Reporter: | Thomas Klausner <domm> |
Component: | Test Suite | Assignee: | Chris Cormack <chris> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Bug Depends on: | 34739 | ||
Bug Blocks: | |||
Attachments: |
Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739
Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739 |
Description
Thomas Klausner
2025-04-22 19:23:10 UTC
Created attachment 181309 [details] [review] Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739 Bug 34739 added some test cases to t/db_dependent/Authority/Merge.t which work when run as a standlone test, but fail when run with some other tests. This patch fixes the test. Test Plan: * Start KTD and enter a shell * Run only the single test: prove t/db_dependent/Authority/Merge.t * You should get "All test successful" * Now run two tests: prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t * You will get a FAIL: t/db_dependent/Authority/Merge.t (Wstat: 256 (exited 1) Tests: 14 Failed: 1) Failed test: 13 * Apply the patch * Again run two tests: prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t * You should get "All test successful" Sponsored by: HKS3 Created attachment 181310 [details] [review] Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739 Bug 34739 added some test cases to t/db_dependent/Authority/Merge.t which work when run as a standlone test, but fail when run with some other tests. This patch fixes the test. Test Plan: * Start KTD and enter a shell * Run only the single test: prove t/db_dependent/Authority/Merge.t * You should get "All test successful" * Now run two tests: prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t * You will get a FAIL: t/db_dependent/Authority/Merge.t (Wstat: 256 (exited 1) Tests: 14 Failed: 1) Failed test: 13 * Apply the patch * Again run two tests: prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t * You should get "All test successful" Sponsored by: HKS3 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Great detective work, thanks a lot, Thomas! Picking this out of the queue :) Pushed for 25.05! Well done everyone, thank you! |