Description
Matt Blenkinsop
2025-04-23 15:23:01 UTC
Created attachment 181453 [details] [review] Bug 39711: Add koha objects for the aqcontract table Created attachment 181454 [details] [review] Bug 39711: Update all calls to GetContracts Created attachment 181455 [details] [review] Bug 39711: Update all calls to GetContract Created attachment 181456 [details] [review] Bug 39711: Update call to AddContract Created attachment 181457 [details] [review] Bug 39711: Update call to ModContract and improve error handling Created attachment 181458 [details] [review] Bug 39711: Update call to DelContract Created attachment 181459 [details] [review] Bug 39711: Add unit tests Created attachment 181460 [details] [review] Bug 39711: Delete old C4::Contract code and tests Created attachment 181461 [details] [review] Bug 39711: Delete old C4::Contract code and tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/* 2) Navigate to a vendor record and access the contracts area 3) Test all CRUD elements for the contracts section 4) Navigate to the baskets for the vendor 5) Test the available CRUD options for a basket 6) All pages should work as expected Created attachment 181580 [details] [review] Bug 39711: Delete old C4::Contract code and tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/* 2) Navigate to a vendor record and access the contracts area 3) Test all CRUD elements for the contracts section 4) Navigate to the baskets for the vendor 5) Test the available CRUD options for a basket 6) All pages should work as expected (In reply to Jonathan Druart from comment #10) > Created attachment 181580 [details] [review] [review] > Bug 39711: Delete old C4::Contract code and tests Simple rebase. Created attachment 181581 [details] [review] Bug 39711: Fix 500 when viewing a basket without contract Can't call method "contractname" on an undefined value at /kohadevbox/koha/acqui/basket.pl line 462. Use Koha::Acq::Basket->contract Created attachment 181582 [details] [review] Bug 39711: Remove ->store It's NOT NULL at the DB level, we don't need to deal with that constraint here. Created attachment 181583 [details] [review] Bug 39711: Fix 500 when creating a new order for a basket without contract Created attachment 181584 [details] [review] Bug 39711: Use ->contract for basketheader Found a bug, that is in main already. You cannot empty a contact when editing a basket. TODO later. Found another bug, in main as well: if you edit a basket that has an inactive contract, it does not appear in the dropdown list. Created attachment 181586 [details] [review] Bug 39711: (bugfix) Show contract of the basket if inactive If the contract is inactive it should be displayed on the basket edit view. Created attachment 181587 [details] [review] Bug 39711: Order by contract name Created attachment 181588 [details] [review] Bug 39711: (bugfix) Allow to clear basket's contract (In reply to Jonathan Druart from comment #20) > Created attachment 181588 [details] [review] [review] > Bug 39711: (bugfix) Allow to clear basket's contract Opened bug 39758 for stable releases. (In reply to Jonathan Druart from comment #18) > Created attachment 181586 [details] [review] [review] > Bug 39711: (bugfix) Show contract of the basket if inactive > > If the contract is inactive it should be displayed on the basket edit > view. And bug 39759 for this one. |