Summary: | Daylight savings breaks circulation (when DST change eliminates 00:00 to 00:59) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | CONFIRMED --- | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Katrin Fischer
2025-04-25 13:42:12 UTC
Confirmed for now in 22.11.23 It appears in main it also breaks the API: * In ktd: edit koha-conf.xml and add Africa/Cairo to timezone element * restart_all * Patron search breaks: [2025/04/25 14:41:10] [ERROR] GET /api/v1/patrons: unhandled exception (Mojo::Exception)<<Invalid local time for date in time zone: Africa/Cairo>> It also still breaks the patron start page: * Click on the "My account" link in the upper right corner - Error 500 OK: This morning the patron searches work again, but we expect another breakage in a year. This bug will affect all libraries in countries where the daylight savings take place between 00:00 and 1:00. It appears it's not that many countries handling it that way currently, but this can always change in our experience. https://en.wikipedia.org/wiki/Daylight_saving_time_by_country (In reply to Katrin Fischer from comment #4) > OK: This morning the patron searches work again, but we expect another > breakage in a year. I tried some tests but wasn't able to reproduce it. It would be good for someone to try setting their system clock to sometime on 2025-04-25 Africa/Cairo time and giving it a go. -- It would be handy to have a very specific "Steps to reproduce" though. Just like as if it was a test plan. I tested on April 25, so I am not quite sure about the part, where you set the system time, but apart from that, I already wrote the test plan: * Update (In reply to Katrin Fischer from comment #2) > It appears in main it also breaks the API: > > * In ktd: edit koha-conf.xml and add Africa/Cairo to timezone element > * restart_all > * Patron search breaks: > > [2025/04/25 14:41:10] [ERROR] GET /api/v1/patrons: unhandled exception > (Mojo::Exception)<<Invalid local time for date in time zone: Africa/Cairo>> (In reply to Katrin Fischer from comment #6) > I tested on April 25, so I am not quite sure about the part, where you set > the system time, but apart from that, I already wrote the test plan: > > * Update (In reply to Katrin Fischer from comment #2) > > It appears in main it also breaks the API: > > > > * In ktd: edit koha-conf.xml and add Africa/Cairo to timezone element > > * restart_all > > * Patron search breaks: > > > > [2025/04/25 14:41:10] [ERROR] GET /api/v1/patrons: unhandled exception > > (Mojo::Exception)<<Invalid local time for date in time zone: Africa/Cairo>> But what are the actual steps? Is it the following? Test plan: 1. vi /etc/koha/sites/kohadev/koha-conf.xml 2. Add "Africa/Cairo" to the timezone element" 3. restart_all 4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 5. Type "anything" into the search box and click the arrow button to search 6. Note the popup that says "Something went wrong when loading the table" 7. Note the following error in /var/log/koha/kohadev/plack-api-error.log [2025/04/25 14:41:10] [ERROR] GET /api/v1/patrons: unhandled exception (Mojo::Exception)<<Invalid local time for date in time zone: Africa/Cairo Yes, that's correct. |