Summary: | OPAC ILL form does not use client-side form validation for required fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Signed Off --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39773: Add 'required' attribute for required fields
Bug 39773: Add 'required' attribute for required fields Bug 39773: Add 'required' attribute for required fields |
Description
Pedro Amorim
2025-04-29 12:23:10 UTC
Created attachment 181649 [details] [review] Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. Created attachment 181650 [details] [review] Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. Created attachment 182009 [details] [review] Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |