Bug 39774

Summary: OPAC ILL Unauthenticated request details table not styled correctly
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Signed Off --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: trivial    
Priority: P5 - low CC: david, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36197    
Bug Blocks:    
Attachments: Bug 39774: Add id to wrapper
Bug 39774: Add id to wrapper
Screenshot - ILL request page after the patch
OPAC logged in request page

Description Pedro Amorim 2025-04-29 13:02:30 UTC

    
Comment 1 Pedro Amorim 2025-04-29 13:11:00 UTC
Created attachment 181654 [details] [review]
Bug 39774: Add id to wrapper

This makes it so that the established styling (seen from request details
page on OPAC, authenticated) is also applied here.

To test, before applying patch:
1) Enabled ILLModule and ILLOpacUnauthenticatedRequest
2) Create an unauth OPAC request: logout and visit:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form
3) Enter the required fields, select type = 'Chapter', add some metadata info such as 'Place of publication', 'Publisher' and others.
4) Notice how the 'Request details' table is rendered, 'Place of
   publication' and 'Publisher' and misaligned. Apply patch. Refresh.
Comment 2 David Nind 2025-04-29 14:13:48 UTC
Created attachment 181664 [details] [review]
Bug 39774: Add id to wrapper

This makes it so that the established styling (seen from request details
page on OPAC, authenticated) is also applied here.

To test, before applying patch:
1) Enabled ILLModule and ILLOpacUnauthenticatedRequest
2) Create an unauth OPAC request: logout and visit:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form
3) Enter the required fields, select type = 'Chapter', add some metadata info such as 'Place of publication', 'Publisher' and others.
4) Notice how the 'Request details' table is rendered, 'Place of
   publication' and 'Publisher' and misaligned. Apply patch. Refresh.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-04-29 14:16:12 UTC
Created attachment 181665 [details]
Screenshot - ILL request page after the patch

I've signed off, as this improves the page.

Is the data supposed to be aligned in the centre and formatted as a table, or should it be like the rest of the request above? (See screenshot.)
Comment 4 Pedro Amorim 2025-04-29 14:24:17 UTC
Created attachment 181667 [details]
OPAC logged in request page

(In reply to David Nind from comment #3)
> I've signed off, as this improves the page.
> 
> Is the data supposed to be aligned in the centre and formatted as a table,
> or should it be like the rest of the request above? (See screenshot.)

Thank you David.

The purpose of the patch is to bring the unauthenticated request page in line with the regular authenticated one (submitted as attachment).
Further improvements can be discussed but that was not my goal with that patch specifically.
Comment 5 David Nind 2025-04-29 18:55:01 UTC
(In reply to Pedro Amorim from comment #4)
> Created attachment 181667 [details]
> OPAC logged in request page
> 
> (In reply to David Nind from comment #3)
> > I've signed off, as this improves the page.
> > 
> > Is the data supposed to be aligned in the centre and formatted as a table,
> > or should it be like the rest of the request above? (See screenshot.)
> 
> Thank you David.
> 
> The purpose of the patch is to bring the unauthenticated request page in
> line with the regular authenticated one (submitted as attachment).
> Further improvements can be discussed but that was not my goal with that
> patch specifically.

That makes sense! Thanks. David