Summary: | ILL History Check does not show in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Signed Off --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the ILL history check tests. It also restores the ILL history check when creating an ILL request in the OPAC. If a potential duplicate request is made (for example the patron has already made a request using the same DOI, Pubmed ID, or ISBN), it now displays the request history check page (when the ILLHistoryCheck system preference is enabled).
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 38441 | ||
Bug Blocks: | |||
Attachments: |
Bug 39777: Rollback tests
Bug 39777: Use cardnumber OR authenticated user cardnumber Bug 39777: Use cardnumber OR authenticated user cardnumber Bug 39777: Rollback tests Bug 39777: Use cardnumber OR authenticated user cardnumber |
Description
Pedro Amorim
2025-04-29 15:32:47 UTC
I was wrong in this comment in bug 38441: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441#c73 The test failing was in fact a new bug I was introduced, as the cardnumber does not exist for authenticated patrons on the OPAC. Created attachment 181671 [details] [review] Bug 39777: Rollback tests These tests should test an authenticated patron, without the presence of a cardnumber in the metadata (as it is the case in the OPAC form) This is also the reason why we mock_userenv right below this. Created attachment 181672 [details] [review] Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. Created attachment 181674 [details] [review] Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. Test plan for UI: 1) Enable ILLModule and ILLHistoryCheck 2) Create a new ILL on OPAC, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Select type="journal", enter DOI = "123". Create. 4) Repeat steps 2 and 3. A history check screen should be displayed (it is not, before this patch). Created attachment 181692 [details] [review] Bug 39777: Rollback tests These tests should test an authenticated patron, without the presence of a cardnumber in the metadata (as it is the case in the OPAC form) This is also the reason why we mock_userenv right below this. Signed-off-by: David Nind <david@davidnind.com> Created attachment 181693 [details] [review] Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. Test plan for UI: 1) Enable ILLModule and ILLHistoryCheck 2) Create a new ILL on OPAC, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Select type="journal", enter DOI = "123". Create. 4) Repeat steps 2 and 3. A history check screen should be displayed (it is not, before this patch). Signed-off-by: David Nind <david@davidnind.com> |