Bug 39796

Summary: Format discount and tax rate code should be moved out of the vue component
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: 24.11   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 38010    
Bug Blocks:    

Description Jonathan Druart 2025-04-30 19:38:47 UTC
vue/components/Vendors/VendorOrderingInformation.vue

+        formatTaxRate(taxRate) {
+            if (!taxRate) return 0;
+            const decimalPlaces = taxRate.toString().split(".")[1]?.length || 0;
+            const multiplier = 10 ** decimalPlaces;
+            return Math.round(taxRate * multiplier) / (multiplier / 100);
+        },
+        formatDiscount() {
+            if (!this.vendor.discount) return 0.0;
+            const decimalPlaces =
+                this.vendor.discount.toString().split(".")[1]?.length || 0;
+            if (decimalPlaces) {
+                return this.vendor.discount;
+            } else {
+                return this.vendor.discount.toFixed(1);
+            }
+        },

This should not be there. Ideally it should be in a js file that would be reusable from outside vue.