Bug 39832

Summary: Add $basket->vendor() method
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: emmi.takkinen, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on:    
Bug Blocks: 32266    
Attachments: Bug 39832: Unit tests
Bug 39832: Add $basket->vendor method
Bug 39832: Unit tests
Bug 39832: Add $basket->vendor method
Bug 39832: Unit tests
Bug 39832: Add $basket->vendor method
Bug 39832: Unit tests
Bug 39832: Add $basket->vendor method

Description Tomás Cohen Arazi (tcohen) 2025-05-05 12:12:09 UTC
For API usage, we need such method.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-05-05 12:15:56 UTC
Created attachment 181911 [details] [review]
Bug 39832: Unit tests
Comment 2 Tomás Cohen Arazi (tcohen) 2025-05-05 12:15:59 UTC
Created attachment 181912 [details] [review]
Bug 39832: Add $basket->vendor method

This patch adds the method to be used on the API for embedding.
Tests are added.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Comment 3 Roman Dolny 2025-05-05 21:19:21 UTC
Created attachment 181949 [details] [review]
Bug 39832: Unit tests

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Roman Dolny 2025-05-05 21:19:24 UTC
Created attachment 181950 [details] [review]
Bug 39832: Add $basket->vendor method

This patch adds the method to be used on the API for embedding.
Tests are added.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Emmi Takkinen 2025-05-08 05:49:34 UTC
Created attachment 182060 [details] [review]
Bug 39832: Unit tests

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 6 Emmi Takkinen 2025-05-08 05:50:02 UTC
Created attachment 182061 [details] [review]
Bug 39832: Add $basket->vendor method

This patch adds the method to be used on the API for embedding.
Tests are added.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 7 Martin Renvoize (ashimema) 2025-05-08 14:59:44 UTC
Created attachment 182088 [details] [review]
Bug 39832: Unit tests

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 8 Martin Renvoize (ashimema) 2025-05-08 14:59:47 UTC
Created attachment 182089 [details] [review]
Bug 39832: Add $basket->vendor method

This patch adds the method to be used on the API for embedding.
Tests are added.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 9 Katrin Fischer 2025-05-09 07:01:03 UTC
Nice constant use of vendor :) Bonus points for terminology!
Comment 10 Katrin Fischer 2025-05-09 07:14:42 UTC
Pushed for 25.05!

Well done everyone, thank you!