| Summary: | Club holds API missing tests | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 25787 | ||
| Bug Blocks: | |||
| Attachments: | Bug 39869: Add more tests for the club holds endpoint | ||
|
Description
Tomás Cohen Arazi (tcohen)
2025-05-09 13:55:48 UTC
Created attachment 182177 [details] [review] Bug 39869: Add more tests for the club holds endpoint This patch does: * Mock `CanItemBeReserved` and `CanBookBeReserved` to better control the test scenario and make it agnostic from existing data. * Adds tests for the item-level group holds use case * Adds tests for the warnings printed when placing the hold should not be possible To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/clubs_holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Test suite related, no changes to the manual required. |