Bug 39886

Summary: [24.11] Identifier typed as Identifierr
Product: Koha Reporter: Anneli Österman <anneli.osterman>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to stable --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: david, paul.derscheid
Version: 24.11   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.05
Circulation function:
Attachments: Bug 39886: [24.11.x] Identifier typed as Identifierr
Bug 39886: [24.11.x] Identifier typed as Identifierr

Description Anneli Österman 2025-05-13 05:30:29 UTC
There is a typo in version 24.11 mappings.tt

https://github.com/Koha-Community/Koha/blob/24.11.x/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt#L294

There is word 'Identifyerr' when it should be 'Identifyer' with only one r at the end.

I found it while translating: https://translate.koha-community.org/translate/koha/24-11/staff-prog/fi/?checksum=30130bcb0b8d25d6
Comment 1 Owen Leonard 2025-05-14 16:01:10 UTC
Created attachment 182459 [details] [review]
Bug 39886: [24.11.x] Identifier typed as Identifierr

This patch corrects a typo in the Elasticsearch mappings template:

Identifierr -> Identifier

To test, apply the patch and go to Administration -> Search engine
configuration. In the "Type" column, check the dropdown menus. There
should be an item "Identifier."
Comment 2 David Nind 2025-05-14 21:10:13 UTC
Created attachment 182472 [details] [review]
Bug 39886: [24.11.x] Identifier typed as Identifierr

This patch corrects a typo in the Elasticsearch mappings template:

Identifierr -> Identifier

To test, apply the patch and go to Administration -> Search engine
configuration. In the "Type" column, check the dropdown menus. There
should be an item "Identifier."

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-05-14 21:11:26 UTC
Testing notes (using KTD):
1. Note that the incorrect spelling in the type column dropdown list is at the very bottom of the page - in the row without a name label.
Comment 4 Katrin Fischer 2025-05-15 07:18:02 UTC
Progressing this to "Pushed to main" to get it into queue of 24.11 RMaint.
Bug is not actually present in main.
Comment 5 Paul Derscheid 2025-05-22 18:25:18 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05