Summary: | Display a prompt for status alias when completing a request if ILL_STATUS_ALIAS in use | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This enhancement to ILL requests lets you select a 'status alias' when marking requests as complete. This is only shown when values are defined for the ILL_STATUS_ALIAS authorized values category. The alias is then shown in the status field on the request details page, and in the status column for the list of ILL requests. If there are no values defined, then you are not prompted to select a status alias.
|
|
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 39917: Add tests
Bug 39917: Add new optional 'mark_completed' ILL screen Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t Bug 39917: Add tests Bug 39917: Add new optional 'mark_completed' ILL screen Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t |
Description
Pedro Amorim
2025-05-16 11:49:07 UTC
Created attachment 182517 [details] [review] Bug 39917: Add tests prove t/db_dependent/Koha/ILL/Requests.t Created attachment 182518 [details] [review] Bug 39917: Add new optional 'mark_completed' ILL screen This new 'Mark completed' screen only shows when ILL_STATUS_ALIAS is not empty, i.e. Koha installations that are not using ILL_STATUS_ALIAS will not see any change in their workflow. Backends that don't implement 'mark_completed' are inherently already making use of core 'mark_completed' and will automatically adopt this enhancement. Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow. Test plan: 1) Enable ILLModule sys pref 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, cardnumber and library. Click 'Create'. 4) You should now be on the manage request screen. Click 'Confirm' and 'Confirm request'. 5) You should be on the manage request screen again. Click 'Mark completed'. The request's status became 'Completed'. 6) Add at least one AV entry to ILL_STATUS_ALIAS av category, visit: <staff_url>/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=ILL_STATUS_ALIAS 7) Add 'abc_code' to 'Authorized value' and 'abc_description' to 'Description'. Click 'Save'. 8) Repeat steps 2 to 5. Notice that when you 'Mark completed' now, a new screen is shown prompting for a status_alias. 9) Pick a status_alias and save. Notice the 'status' now shows the alias. Sponsored-by: NHS England Created attachment 182541 [details] [review] Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t prove xt/find-missing-filters.t Created attachment 183091 [details] [review] Bug 39917: Add tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 183092 [details] [review] Bug 39917: Add new optional 'mark_completed' ILL screen This new 'Mark completed' screen only shows when ILL_STATUS_ALIAS is not empty, i.e. Koha installations that are not using ILL_STATUS_ALIAS will not see any change in their workflow. Backends that don't implement 'mark_completed' are inherently already making use of core 'mark_completed' and will automatically adopt this enhancement. Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow. Test plan: 1) Enable ILLModule sys pref 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, cardnumber and library. Click 'Create'. 4) You should now be on the manage request screen. Click 'Confirm' and 'Confirm request'. 5) You should be on the manage request screen again. Click 'Mark completed'. The request's status became 'Completed'. 6) Add at least one AV entry to ILL_STATUS_ALIAS av category, visit: <staff_url>/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=ILL_STATUS_ALIAS 7) Add 'abc_code' to 'Authorized value' and 'abc_description' to 'Description'. Click 'Save'. 8) Repeat steps 2 to 5. Notice that when you 'Mark completed' now, a new screen is shown prompting for a status_alias. 9) Pick a status_alias and save. Notice the 'status' now shows the alias. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> Created attachment 183093 [details] [review] Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: David Nind <david@davidnind.com> (In reply to Pedro Amorim from comment #2) > Backends that do implement their own mark_completed don't automatically > adopt this enhancement and will not see any change in their workflow. This is false. 'mark_completed' is always used by core and requests from any backend will adopt this new feature, meaning the screen will show as long as ILL_STATUS_ALIAS is in use. I've updated the bug title to clarify this further. The release notes are accurate as is. If that were required, a new backend_mark_completed in Koha::ILL::Request would need to be implemented and ill-requests.pl would have to invoke that instead (similar to how it does for backend_cancel or backend_confirm). Should the above be required it should be a new bug entry as it's a change in behavior. The feature in this patchset works as intended, I just wanted to correct my original comment. |