Bug 39977

Summary: Prevent reserves of items the users have already on their possession
Product: Koha Reporter: Adolfo Rodríguez Taboada <adolfo.rodriguez>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: anneli.osterman, gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 39977 - Prevent reserves of items the users have already on their possession This patch preventes users from placing a hold on item they haved checked out.

Description Adolfo Rodríguez Taboada 2025-05-23 07:59:56 UTC
When the system preference AllowHoldsOnPatronsPossessions is set to Allow users can request holds on biblio records they have items checked out from. That includes the very items they already have in their possession. 

I think Koha should check at the item level that you don't already have this item.  As I see this system preference, it should only allow to request a hold on the other items.

For example, the bibliographic record is a manga series of several volumes. The user has checked the first volume, the system should let them to put a hold on the second volume, but not on the first one.
Comment 1 Adolfo Rodríguez Taboada 2025-05-23 08:05:31 UTC
Created attachment 182753 [details] [review]
Bug 39977 - Prevent reserves of items the users have already on their possession This patch preventes users from placing a hold on item they haved checked out.

1 Turn system preference AllowHoldsOnPatronsPossessions to Allow.
2 Check out an item from a record with more than one item.
3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has.
4 Apply patch, restart services
5 Repeat step 3. Now you cannot select the item the user has checked out.
Comment 2 Katrin Fischer 2025-05-23 11:34:03 UTC
Does the test plan really make sense?

1 Turn system preference AllowHoldsOnPatronsPossessions to Allow.

So a hold on the item in my possession should be allowed. But your test plan ends with: 

3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has.
4 Apply patch, restart services
5 Repeat step 3. Now you cannot select the item the user has checked out.

I don't think that is correct.
Comment 3 Adolfo Rodríguez Taboada 2025-05-23 11:40:35 UTC
The point is that the user shouldn't be able to put a hold on the item that's already on their possession. With the AllowHoldsOnPatronsPossessions on Allow they should be able to put a hold on any other item.

An example.

A bibliographic record of Paradise Kiss, a manga series collected in 5 volumes.
The user has checked out an item (Volume 1) and wants to put a hold on a different item (Volume 2) That should be allowed with the preference AllowHoldsOnPatronsPossessions. It makes sense to want to reserve the next volume to continue reading the series.

I think the user shouldn't be allowed to put a hold in the item of Volume 1 as he/she has already that item.
Comment 4 Katrin Fischer 2025-05-23 11:42:50 UTC
It's a change in behavior not everyone might agree with. This feature has been existing for a long while now, so it might be an unwanted change for some if it hasn't been reported as a problem so far.
Comment 5 Adolfo Rodríguez Taboada 2025-05-23 13:37:37 UTC
This was reported as a problem by a client, as they did want to allow reserves on bibliographic records when the user had some items checked out but not those specific items.

We could rework it as a third option in the system preference AllowHoldsOnPatronsPossessions
Comment 6 Anneli Österman 2025-06-16 11:42:26 UTC
We have libraries tht have AllowHoldsOnPatronsPossessions set to Allow and it would be nice if it remained the same as before. Maybe a third option as suggested?

I do not see why we should prevent patrons to make hold on the very same item they already have checked out. It is not our place to say that they cannot do it. If they need the same item, they can have it. :)