Bug 40036

Summary: Purchase suggestion status column no longer displays reason
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: AcquisitionsAssignee: Lucas Gass (lukeg) <lucas>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: chessa, david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This restores the display of suggestion accept or reject reasons (from the SUGGEST authorized values category) in the status column for the list of purchase suggestions. (This is related to Bug 33430 - Use REST API for suggestions tables, added in Koha 25.05.) It also adds classes for the SUGGEST authorized values, so that these can be styled.
Version(s) released in:
25.11.00,25.05.01
Circulation function:
Attachments: 24.11 View
Bug 40036: Add reason back to status column and add classes/data attributes
Bug 40036: Add reason back to status column and add classes/data attributes
Bug 40036: Add reason back to status column and add classes/data attributes

Description Lucas Gass (lukeg) 2025-05-30 13:47:01 UTC
Created attachment 182860 [details]
24.11 View

Prior to Bug 33430 the purchase suggestion table would include the reason, if it exists, in the status column.
Comment 1 Lucas Gass (lukeg) 2025-05-30 14:27:28 UTC
While at it, it would be nice to include some classes or data attributes to make CSS customization easier.
Comment 2 Lucas Gass (lukeg) 2025-05-30 14:31:00 UTC
Created attachment 182861 [details] [review]
Bug 40036: Add reason back to status column and add classes/data attributes

To test:
0. APPLY PATCH
1. Make a few AVs for SUGGEST ( reason ) and SUGGEST_STATUS ( status ).
2. Make some new suggestions and give them new statues w/ a reason.
3. The reason should display, in parentheses, in the status column.
4. There should be a status class and a reason class for each.
Comment 3 David Nind 2025-05-31 13:02:28 UTC
Created attachment 182879 [details] [review]
Bug 40036: Add reason back to status column and add classes/data attributes

To test:
0. APPLY PATCH
1. Make a few AVs for SUGGEST ( reason ) and SUGGEST_STATUS ( status ).
2. Make some new suggestions and give them new statues w/ a reason.
3. The reason should display, in parentheses, in the status column.
4. There should be a status class and a reason class for each.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2025-06-06 07:11:27 UTC
Created attachment 183046 [details] [review]
Bug 40036: Add reason back to status column and add classes/data attributes

To test:
0. APPLY PATCH
1. Make a few AVs for SUGGEST ( reason ) and SUGGEST_STATUS ( status ).
2. Make some new suggestions and give them new statues w/ a reason.
3. The reason should display, in parentheses, in the status column.
4. There should be a status class and a reason class for each.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Lucas Gass (lukeg) 2025-06-06 15:45:51 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-06-22 21:47:21 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03