| Summary: | Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | Command-line Utilities | Assignee: | Hammat wele <hammat.wele> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, hammat.wele, noah.tremblay, philippe.blouin, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl
Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl |
||
|
Description
Caroline Cyr La Rose
2025-06-04 20:26:49 UTC
Created attachment 183769 [details] [review] Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl This patch adds a new parameter to skip borrowers without an email address. To test: 1 - Create a new patron without an email address and note their borrowernumber. 2 - Run ./misc/maintenance/borrowers-force-messaging-defaults.pl ==> The patron created in step 1 should be processed. 3 - Repeat step 2 with the --skip-no-email parameter. ==> The patron created in step 1 should not be processed. Created attachment 186208 [details] [review] Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl This patch adds a new parameter to skip borrowers without an email address. To test: 1 - Create a new patron without an email address and note their borrowernumber. 2 - Run ./misc/maintenance/borrowers-force-messaging-defaults.pl ==> The patron created in step 1 should be processed. 3 - Repeat step 2 with the --skip-no-email parameter. ==> The patron created in step 1 should not be processed. Signed-off-by: noah <noah@inlibro.com> Works well for me, but ideally we’d need another developer, not from inLibro, to Signoff. Testing here... 1) QA checks - passing! 2) Code review a) Check for existence of email (question) The script uses an SQL statement that checks, if email, emailpro and B_email are empty to determine that the settings should not be set. I wonder if it would make sense to take the system preferences like EmailFieldPrimary into account, using Koha's method for determining the email address to send a notice to is not empty? b) Missing documentation (blocker) The new option is added, but wasn't added to the help. As the script already runs without any options, the new option is not discoverable apart from reading the code. It might also be worth noting how it works (see a) ). |