Description
Jonathan Druart
2025-06-11 14:40:54 UTC
Created attachment 183167 [details] [review] Bug 40121: Add Cypress tests Created attachment 183168 [details] [review] Bug 40121: Fix library and category filters on patron search Test plan: Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl Select a value for Library and/or Category filters Click "Search" => Without this patch the dropdown lists do not have the value selected => With this patch applied they have the correct values selected I unfortunately can't signoff on this, for two main reasons: One--the changes fail QA FAIL t/cypress/integration/KohaTable/PatronSearch_spec.ts FAIL forbidden patterns forbidden pattern: .only detected (line 130) Two--the provided Cypress tests do not pass 1) Filters Keep filters in the column filters: Timed out retrying after 10000ms + expected - actual -'^CPL$' at Context.eval (webpack://koha/./t/cypress/integration/KohaTable/PatronSearch_spec.ts:178:14) Created attachment 183217 [details] [review] Bug 40121: Add Cypress tests (In reply to David Flater from comment #3) > I unfortunately can't signoff on this, for two main reasons: Sorry about that, I should have run the QA script. It also seems that I have added a couple of trivial tests that I haven't retried before submitting the patches! Created attachment 183224 [details] [review] Bug 40121: Fix library and category filters on patron search Test plan: Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl Select a value for Library and/or Category filters Click "Search" => Without this patch the dropdown lists do not have the value selected => With this patch applied they have the correct values selected Signed-off-by: David Nind <david@davidnind.com> Created attachment 183225 [details] [review] Bug 40121: Add Cypress tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 184664 [details] [review] Bug 40121: Fix library and category filters on patron search QA tools are happy -- everything looks good and works as described. Passing QA here. Test plan: Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl Select a value for Library and/or Category filters Click "Search" => Without this patch the dropdown lists do not have the value selected => With this patch applied they have the correct values selected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 184665 [details] [review] Bug 40121: Add Cypress tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Sorry forgot to test cypress tests and they are failing Created attachment 184707 [details] [review] Bug 40121: Fix 'Cannot read properties of undefined' Same fix as commit 7bc3b24827799bee61a6672db78e12a70ee78ccf Bug 40344: Fix KohaTable_spec.ts > Cannot read properties of undefined (reading 'description') Yes indeed, it started to fail after I submitted the patch. Thanks! Created attachment 185001 [details] [review] Bug 40121: Fix library and category filters on patron search Test plan: Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl Select a value for Library and/or Category filters Click "Search" => Without this patch the dropdown lists do not have the value selected => With this patch applied they have the correct values selected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 185002 [details] [review] Bug 40121: Add Cypress tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 185003 [details] [review] Bug 40121: Fix 'Cannot read properties of undefined' Same fix as commit 7bc3b24827799bee61a6672db78e12a70ee78ccf Bug 40344: Fix KohaTable_spec.ts > Cannot read properties of undefined (reading 'description') Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 |