Summary: | Deleting an item does not warn about an item level hold | ||
---|---|---|---|
Product: | Koha | Reporter: | Anni Mäki-Mantila <anni.maki-mantila> |
Component: | Cataloging | Assignee: | Johanna Räisä <johanna.raisa> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | johanna.raisa, kebliss, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 40154: prevent deletion of items with holds
Bug 40154: prevent deletion of items with holds Bug 40154: (follow-up) Minor tidy |
Description
Anni Mäki-Mantila
2025-06-17 07:36:43 UTC
Created attachment 185216 [details] [review] Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Created attachment 185406 [details] [review] Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 185407 [details] [review] Bug 40154: (follow-up) Minor tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> |