Summary: | ILL Patron Has No Email Address on File message upon "Send Notice To Patron" | ||
---|---|---|---|
Product: | Koha | Reporter: | Susan McLeran <tech> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | Pushed to stable --- | QA Contact: | Lisette Scheer <lisette> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, lisette, lucas, martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | Keywords: | additional_work_needed |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
Staff members now receive clear feedback when attempting to send ILL notices to patrons who have no email address on file or haven't configured their messaging preferences for interlibrary loan notifications.
Previously, when clicking "Send notice to patron" for an ILL request, staff received no indication whether the notice was successfully queued for delivery. If the patron had no email address or hadn't opted in to ILL messaging preferences, the notice would silently fail to send, leaving staff unaware that the patron wasn't notified.
With this enhancement:
- A warning message now displays if the notice cannot be queued: "The requested notice was NOT queued for delivery by email, SMS"
- A success message displays when the notice is successfully queued
- Staff can immediately see when they need to contact the patron through alternative means (such as telephone)
**For staff:** If you see the warning message, check the patron's record to ensure:
1. They have a valid email address on file
2. They have enabled ILL messaging preferences (Interlibrary loan ready / Interlibrary loan unavailable) in their patron messaging preferences
|
|
Version(s) released in: |
25.11.00,25.05.02
|
Circulation function: | |
Attachments: |
Bug 40171: Fix tt param name
Bug 40171: Remove extraneous join() Bug 40171: Return fail if no transports for patron Bug 40171: Fix tt param name Bug 40171: Remove extraneous join() Bug 40171: Return fail if no transports for patron Bug 40171: Fix tt param name Bug 40171: Remove extraneous join() Bug 40171: Return fail if no transports for patron Bug 40171: Fix tt param name Bug 40171: Remove extraneous join() Bug 40171: Return fail if no transports for patron Bug 40171: Add tests |
Description
Susan McLeran
2025-06-18 20:33:31 UTC
Created attachment 183383 [details] [review] Bug 40171: Fix tt param name Its tran_fail, not tran_error. Created attachment 183384 [details] [review] Bug 40171: Remove extraneous join() Created attachment 183385 [details] [review] Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Testing notes (using KTD): 1. With no email set for a patron, I now get a message in a yellow background "The requested notice was NOT queued for delivery by email, SMS". 2. However, with a valid email address and a working SMTP server (the patron welcome message is sent after processing the message queue), I still get the same message - that is, the notice is not queued. Created attachment 183593 [details] [review] Bug 40171: Fix tt param name Its tran_fail, not tran_error. Created attachment 183594 [details] [review] Bug 40171: Remove extraneous join() Created attachment 183595 [details] [review] Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. (In reply to David Nind from comment #4) > 2. However, with a valid email address and a working SMTP server (the patron > welcome message is sent after processing the message queue), I still get the > same message - that is, the notice is not queued. Thank you David, I missed some steps on my original test plan: 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Can you please give it another go when possible? Created attachment 183627 [details] [review] Bug 40171: Fix tt param name Its tran_fail, not tran_error. Signed-off-by: David Nind <david@davidnind.com> Created attachment 183628 [details] [review] Bug 40171: Remove extraneous join() Signed-off-by: David Nind <david@davidnind.com> Created attachment 183629 [details] [review] Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Signed-off-by: David Nind <david@davidnind.com> Created attachment 184157 [details] [review] Bug 40171: Fix tt param name Its tran_fail, not tran_error. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Created attachment 184158 [details] [review] Bug 40171: Remove extraneous join() Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Created attachment 184159 [details] [review] Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 The changes to the pm file are not covered by tests. Created attachment 184186 [details] [review] Bug 40171: Add tests prove t/db_dependent/Koha/ILL/Requests.t (In reply to Jonathan Druart from comment #16) > The changes to the pm file are not covered by tests. Patch submitted. Added 'additional_work_needed' keyword to alert Lucas of this follow-up. Nice work everyone! Pushed to 25.05.x (In reply to Pedro Amorim from comment #18) > (In reply to Jonathan Druart from comment #16) > > The changes to the pm file are not covered by tests. > > Patch submitted. Added 'additional_work_needed' keyword to alert Lucas of > this follow-up. OK I wait for backport on 24.11.x follow-up pushed to main. |