Summary: | The --send-all option in the stockrotation job fails if there are no items to rotate at all | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Cataloging | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aude.charillon, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 40225: Check stationary items for stockrotation
Bug 40225: Send stockrotation report even when all items are stationary |
Description
Martin Renvoize (ashimema)
2025-06-24 11:44:54 UTC
Created attachment 183444 [details] [review] Bug 40225: Check stationary items for stockrotation We should send the report even if all items are stationary Created attachment 183445 [details] [review] Bug 40225: Send stockrotation report even when all items are stationary The stockrotation cronjob was only sending email reports when there were actionable items (items that needed to be moved between branches). This meant that libraries would not receive any notification when all items in their rotation were stationary, even when the --send-all flag was passed to the script. This patch modifies the report logic to also send reports when there are only stationary items, ensuring libraries have visibility into the complete status of their stock rotation items. Test plan: 1. Set up a stock rotation rota with items that are all stationary (items that should stay at their current branch) 2. Run the stockrotation cronjob: perl misc/cronjobs/stockrotation.pl 3. Without this patch: No email report is generated 4. Apply this patch 5. Run the cronjob again 6. Verify that an email report is now generated showing the stationary items 7. Test with mixed scenarios (some actionable, some stationary items) 8. Confirm reports are sent in all cases where items exist in the rotation |